This revision was automatically updated to reflect the committed changes.
Closed by commit R120:727db59f21b0: Move power management checkbox to the top
(authored by ngraham).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8607?vs=21736&id=21764
REVIS
mart accepted this revision.
mart added a comment.
yeah, go for it for now
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik, mck182, davidedmundson, mart
Cc: mart, jensreuterberg, davidedmundson,
ngraham added a comment.
That's fine. I was just aiming for a small improvement here and to get a bug
closed.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik, mck182, davidedmundson
Cc: mart, je
mart added a comment.
Let me explain the situation a bit: HIG for the systray content is in
progress (and no, it won't be a complete redesign, but just a formalization of
the best charateristic of the current plasmoids) so some modules *might* have
to be partly reorganized afterwards.
an i
jensreuterberg added a comment.
Say FOR EXAMPLE (an example, not a clear suggestion or goal) - we could
design all popups to follow a simple layout like this https://imgur.com/a/xbGt1
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8607
To:
jensreuterberg added a comment.
To be quite honest I don't think there is a complete agreement on the layouts
of the systray dialogues, although one should be considered - but since systray
dialogues have a bit of a history and there are still plans going about another
systray dialogue layou
broulik added a comment.
I usually just temporarily mess with the dataengine to pretend to have
brightness controls for testing :)
INLINE COMMENTS
> PopupDialog.qml:70
> +onEnabledChanged: powermanagementChanged(enabled)
> +KeyNavigation.tab: batteryList
> +
ngraham added a comment.
I would love to, and in general I do, but I do all my development in a VM,
and my Neon VM doesn't expose a brightness setting, which is the control that
inappropriately appears on top without this change. So the before-and-after
wouldn't be very exciting. :) If anyon
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Generally, if we have a UI change can we include a screenshot - the one thing
we really need to improve is the VDG being in continual feedback loops with
regards to changes.
ngraham added a reviewer: mck182.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik, mck182
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham added reviewers: Plasma: Workspaces, broulik.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8607
To: ngraham, #plasma_workspaces, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 345940
Move the "Enable Power Management" checkbox to the top of the window to match
other applets (bluetooth, network)
REPOSITORY
12 matches
Mail list logo
