This revision was automatically updated to reflect the committed changes.
Closed by commit R133:dd3722248e20: Screenlocker KCM text improvements
(authored by ngraham).
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8686?vs=22011&id=22012
REVISION DETAIL
ngraham marked an inline comment as done.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8686
To: ngraham, abetts, #vdg, #plasma
Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, mart
abetts accepted this revision.
abetts added a comment.
This revision is now accepted and ready to land.
I would agree, keyboard shortcut seems better. It just felt like the label
didn't have context for the shortcut button next to it.
REPOSITORY
R133 KScreenLocker
BRANCH
master
REVISION
ngraham updated this revision to Diff 22011.
ngraham added a comment.
Make this string shorter
REPOSITORY
R133 KScreenLocker
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8686?vs=22001&id=22011
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8686
AFFECTED FILES
apol added inline comments.
INLINE COMMENTS
> kcm.ui:131
>
> -Lock screen:
> +Lock screen with keyboard shortcut:
>
Maybe leave it at `keyboard shortcut`? `Lock screen` is a bit redundant as
we're already at the screen locking page and the text
ngraham edited the test plan for this revision.
REPOSITORY
R133 KScreenLocker
REVISION DETAIL
https://phabricator.kde.org/D8686
To: ngraham, abetts, #vdg, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham created this revision.
ngraham added reviewers: abetts, VDG, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG: 386573
TEST PLAN
Tested in KDE Neon:
REPOSITORY
R133 KScreenLocker
BRANCH
master
R
