D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

This revision was automatically updated to reflect the committed changes. Closed by commit R108:68698b42012c: [libinput] Find screen for touch screen devices and calibrate accordingly (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. CHANGED PRIOR TO

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH libinput-calibrate-touchscreen2 REVISION DETAIL https://phabricator.kde.org/D8748 To: graesslin, #kwin,

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin updated this revision to Diff 24319. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Multiply with default calibration matrix. In order to simplify the matrix multiplication the definitions of the matrices are changed to

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin marked 2 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D8748 To: graesslin, #kwin, #plasma Cc: davidedmundson, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai,

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in device.cpp:464 > Shouldn't we be multiplying the default matrix for the device by the matrix > you're generating here then setting that? > > If a user has set a static calibration we want to keep that. Hmm, you might

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

davidedmundson added a comment. Mostly ship it, but I noticed something in the docs when I was checking the matrices. INLINE COMMENTS > device.cpp:464 > +} > +libinput_device_config_calibration_set_matrix(m_device, matrix.data()); > +} Shouldn't we be multiplying the default matrix

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin updated this revision to Diff 22237. graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Handle deviceAdded REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8748?vs=22175=22237 BRANCH

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin updated this revision to Diff 22175. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Use screens()->geometry() instead of size REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8748?vs=22152=22175 BRANCH

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin marked an inline comment as done. graesslin added inline comments. INLINE COMMENTS > graesslin wrote in connection.cpp:395 > It's failing to compile in tests/ directory. There I don't have the > mockscreens, so I didn't think of it. Will try with the mockscreens. Thanks > for the

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in connection.cpp:395 > not that it's a problem, but why? > You have screens mocked already. It's failing to compile in tests/ directory. There I don't have the mockscreens, so I didn't think of it. Will try with the

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

davidedmundson added a comment. One minor comment (the third one), otherwise all good. INLINE COMMENTS > connection.cpp:395 > case LIBINPUT_EVENT_TOUCH_DOWN: { > +#ifndef KWIN_BUILD_TESTING > TouchEvent *te = static_cast(event.data()); not that

D8748: [libinput] Find screen for touch screen devices and calibrate accordingly

graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This change finds the screen for a touch screen device based on: - number available screens