This revision was automatically updated to reflect the committed changes.
Closed by commit R120:02c3c22c76ae: Only notify if the property changes
(authored by apol).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8819?vs=22349&id=22361
REVISION DETAI
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R120 Plasma Workspace
BRANCH
signals
REVISION DETAIL
https://phabricator.kde.org/D8819
To: apol, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali
apol updated this revision to Diff 22349.
apol added a comment.
Oops
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8819?vs=22347&id=22349
BRANCH
signals
REVISION DETAIL
https://phabricator.kde.org/D8819
AFFECTED FILES
applets/notification
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Concept is fine.
I think you have a typo in the last method.
INLINE COMMENTS
> notificationsapplet.cpp:137
> +if (newPopupPosition != m_popupPosition) {
> +
apol created this revision.
apol added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R120 Plasma Workspace
BRANCH
signals
REVISION DETAIL
https://phabricator.kde.org/D8819
AFFECTED FILES
applets/no
