D9391: [effects] Add 'Fullscreen' effect

zzag abandoned this revision. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. The code is really bloated. Also, I lost interest in developing this effect. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #pl

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24871. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect - Emit `windowFullScreenChanged` signal - Unreference previous pix

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. X11 === F5625140: fullscreen-animation-x11.mp4 Xwayland F5625142: fullscreen-animation-xwayland.mp4

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24849. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect Re-implemented this effect. The only missing part is e

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24718. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect I think this should be rewritten in C++ for several reasons: -

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. So, I've tested this effect on Wayland.. Konsole(XWayland, Qt) = F5611762: fullscreen-konsole-xwayland.mp4 Seems, like cross fad

D9391: [effects] Add 'Fullscreen' effect

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. >> Due to that I personally would prefer if we don't add this for 5.12 or only for Wayland windows. > > Is it okay to support only Wayland? Personally I would prefer to have the code generi

D9391: [effects] Add 'Fullscreen' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9391#184475, @zzag wrote: > In https://phabricator.kde.org/D9391#184440, @abetts wrote: > > > Could you please post a new video with a before and after? I would l

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9391#184440, @abetts wrote: > Could you please post a new video with a before and after? I would like to preview it. Ok, I'll do it later. But keep in mind cod

D9391: [effects] Add 'Fullscreen' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. Could you please post a new video with a before and after? I would like to preview it. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma, graesslin C

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9391#182439, @graesslin wrote: > I'm absolutely against any changed to window gravity on X11. And I'm also not happy with a new animation if we already know that it do

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24524. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect Squash commits. REPOSITORY R108 KWin CHANGES SINCE LAST UPDA

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24522. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect Add fullscreen effect to the effect loader tests. REPOSITORY

D9391: [effects] Add 'Fullscreen' effect

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. As this adds a new effect: all the effectloader autotests need to be adjusted, otherweise the tests will start to fail. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 T

D9391: [effects] Add 'Fullscreen' effect

graesslin requested changes to this revision. graesslin added a comment. This revision now requires changes to proceed. Restricted Application edited projects, added Plasma; removed KWin. A possibility to solve this problem with gtk would be to restrict to Wayland windows. I'm absolutely again

D9391: [effects] Add 'Fullscreen' effect

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. https://phabricator.kde.org/D6799 for the record (I like your patch better, actually, just if you want to look at my implementation) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.o

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24141. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. [effects] Add 'Fullscreen' effect This effect animates transition to/from fullscreen mode. For the most part it is a copy-paste of the Maximize effect with

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Seems like calculation of gravity in `Client::calculateGravitation()` is wrong for gtk apps. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma Cc: grae

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. F5557841: fullscreen_konsole.mp4 F5557844: fullscreen_gimp.mp4 REPOSITORY R108 KWin REVISION DETAIL https://phabrica

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. It seems to be working, but there is a problem with GTK apps. They have wrong positions in their geometries: Output like `"{...} -> {...}"` comes from `geometryChanged`: js geometryChanged

D9391: [effects] Add 'Fullscreen' effect

zzag marked 2 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9391 To: zzag, #kwin, #plasma Cc: graesslin, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9391: [effects] Add 'Fullscreen' effect

zzag updated this revision to Diff 24139. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9391: [effects] Add 'Fullscreen' effect REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricat

D9391: [effects] Add 'Fullscreen' effect

graesslin added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fullscreen.js:4 > + > + Copyright (C) 2012 Martin Gr��lin > + Copyright (C) 2017 Vlad Zagorodniy *cough* utf8 please > metadata.desktop:3 > +Name=Fullscreen > +Name[x-test]=x

D9391: [effects] Add 'Fullscreen' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9391#180624, @broulik wrote: > Thanks for your patch! I did a similar patch a while ago but I didn't submit it as it seems to cause visual glitches with various apps,

D9391: [effects] Add 'Fullscreen' effect

broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. Thanks for your patch! I did a similar patch a while ago but I didn't submit it as it seems to cause visual glitches with various apps, such as when fullscreening Yakuake or Chrome. REPOSITORY R108

D9391: [effects] Add 'Fullscreen' effect

zzag created this revision. zzag added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This effect animates transition to/from fullscreen mode. For the most part it is a copy-paste of the Maxi