rkflx added a comment.
Thanks Nate, your blog readership seems to like it too (congratulations on
the blog, BTW ;) What about the inevitable "But can I change it back?". You
claim we allow this, but if you actually try it, it does not work, i.e. the
menu shadow is now almost completely gone
abetts accepted this revision.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham edited reviewers, added: abetts; removed: apol.
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, hpereiradacosta, abetts
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas,
hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.
Ship it. Thanks !
REPOSITORY
R31 Breeze
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc:
ngraham marked an inline comment as done.
ngraham added a comment.
Thanks for the advice, Hugo. Menu shadows now match the screenshot in the
prior patch that people liked and that https://phabricator.kde.org/tag/vdg/
approved.
REPOSITORY
R31 Breeze
REVISION DETAIL
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
ngraham updated this revision to Diff 24674.
ngraham added a comment.
- Change scale factor in both places
- Use a variable to score the scale factor
- Default to 25% for the scale, to match the prior patch's screenshot (which
people really liked, and VGD agreed to)
REPOSITORY
R31
hpereiradacosta added a comment.
Hi
thanks for the patch !
... see inline comment.
Also note that to more or less match the different scales shown in your
original screenshot, you would need a 0.25% scale (or even 0.20%) rather than
0.5%
But I am also fine with the current
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D9627
To: ngraham, #vdg, #breeze, apol, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,