D9638: [effects] add 'Slide Desktops' effect

zzag created this revision. zzag added reviewers: VDG, KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application edited projects, added Plasma; removed KWin. REVISION SUMMARY Slide Desktops animates switching

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Motivation behind this effect and demos will be soon. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: plasma-devel, kwin, iodelay, bwowk, Zr

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. I've made this effect because I am very disappointed with the Slide effect. Let me list some of the biggest problems with slide effect: - It's not intuitive - It has poor(like my English) visual

D9638: [effects] add 'Slide Desktops' effect

Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D9638: [effects] add 'Slide Desktops' effect

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9638: [effects] add 'Slide Desktops' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. This is great work. I like the results. I like the gap as well. It makes for a good idea of separation. What I would maybe want to add would be some sort of effect, darkening, or slight zooming in/out

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#185547, @abetts wrote: > What I would maybe want to add would be some sort of effect, darkening, or slight zooming in/out when moving a window from one desktop to

D9638: [effects] add 'Slide Desktops' effect

abetts added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#185606, @zzag wrote: > In https://phabricator.kde.org/D9638#185547, @abetts wrote: > > > What I would maybe want to add would be some sort of effect, darkeni

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. > This is good to know. It doesn't look bad right now. Maybe the speed can also clue in the user of what's happening behind. That should be an easier method. So, what do you propose to do? REPOSITO

D9638: [effects] add 'Slide Desktops' effect

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. Overall code looks good for me and the video looks really promising. I fear it's too late for 5.12, which is a pity. INLINE COMMENTS > slidedesktops.cpp:144 > +QRegion clipRegion = buildClipReg

D9638: [effects] add 'Slide Desktops' effect

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. Just putting it as an idea: maybe we should just drop the "old" slide desktop effect and replace it with this one? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zz

D9638: [effects] add 'Slide Desktops' effect

ngraham added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9638#185720, @graesslin wrote: > Just putting it as an idea: maybe we should just drop the "old" slide desktop effect and replace it with this one? +1 REPO

D9638: [effects] add 'Slide Desktops' effect

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > graesslin wrote in slidedesktops.h:60 > As you use modern connect syntax you don't need the Q_SLOTS keyword anymore. Yeah, I know `slots`/`Q_SLOTS` keyword is optional with Qt 5, but

D9638: [effects] add 'Slide Desktops' effect

zzag updated this revision to Diff 24698. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' effect Use QVector instead of QList, replace Q_FOREACH with range-based

D9638: [effects] add 'Slide Desktops' effect

zzag marked 6 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 To: zzag, #vdg, #kwin, #plasma Cc: graesslin, abetts, ngraham, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai

D9638: [effects] add 'Slide Desktops' effect

zzag updated this revision to Diff 24699. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' effect Squash commits. REPOSITORY R108 KWin CHANGES SINCE LAST UPDA

D9638: [effects] add 'Slide Desktops' effect

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > zzag wrote in slidedesktops.h:60 > Yeah, I know `slots`/`Q_SLOTS` keyword is optional with Qt 5, but I would > like to keep it to avoid some misunderstandings(e.g. "who the hell call

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Memory allocations in `SlideDesktopsEffect::paintScreen()` creep me out. We should not allocate memory during paint calls! If you have any ideas how to solve this, please let me know. Currently, I'm thin

D9638: [effects] add 'Slide Desktops' effect

zzag updated this revision to Diff 24932. zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updating https://phabricator.kde.org/D9638: [effects] add 'Slide Desktops' effect - Add 'Slide docks' option REPOSITORY R108 KWin

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added 'Slide docks' option: F5629578: new-option.png We need to disable sliding docks, for example, when using latte-dock. F5629577: slidedesktops-dont

D9638: [effects] add 'Slide Desktops' effect

mart added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#185720, @graesslin wrote: > Just putting it as an idea: maybe we should just drop the "old" slide desktop effect and replace it with this one? +1 REPOSIT

D9638: [effects] add 'Slide Desktops' effect

graesslin added a comment. Restricted Application edited projects, added KWin; removed Plasma. as we had quite positive feedback on the replacement idea: could you please rework the patch to replace the old effect? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9638 T

D9638: [effects] add 'Slide Desktops' effect

zzag added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9638#190031, @graesslin wrote: > as we had quite positive feedback on the replacement idea: could you please rework the patch to replace the old effect? OK.

D9638: [effects] add 'Slide Desktops' effect

zzag updated this revision to Diff 25273. zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Replace old slide effect with this one. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9638?vs=24932&id=25273 BRANCH effects/