This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b7ad4bcf881c: Keep fullscreen windows in active layer
based on transients not the group (authored by graesslin).
Restricted Application edited projects, added KWin; removed Plasma.
REPOSITORY
R108 KW
graesslin updated this revision to Diff 24870.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Check transients recursively by looking at the transients main windows
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
luebking added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
The original implementation based the fullscreen status on the stack position
of the window (ie. whenever a window would rise above the plain stack position
of the FS window, it would loose the FS st
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.
Restricted Application edited projects, added Plasma; removed KWin.
I've tested it with Kate and also multiple screens, and everything worked
fine. On Wayland I couldn't really test it, be
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
In https://phabricator.kde.org/D9699#186972, @graesslin wrote:
> git blame result: The group check was introduced with
https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 -
graesslin added inline comments.
Restricted Application edited projects, added Plasma; removed KWin.
INLINE COMMENTS
> romangg wrote in abstract_client.cpp:1155
> Just a question for understanding unrelated to this patch: why should
> `isActiveFullScreen` return true, if `ac->screen() != screen(
graesslin added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
git blame result: The group check was introduced with
https://phabricator.kde.org/R108:476ca65295bfb3f0d90f535d9930250a13a8b323 -
before it was a check for transient, but the group check was there a
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
In https://phabricator.kde.org/D9699#186940, @romangg wrote:
> Are there maybe other cases of clients in X, which share the same group,
are not transient, but need to have `isActiveFullScreen` r
romangg added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
Are there maybe other cases of clients in X, which share the same group, are
not transient, but need to have `isActiveFullScreen` return true on any client
if one of them is the most recent activated
graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
graesslin requested review of this revision.
Restricted Application edited projects, added Plasma; removed KWin.
REV
10 matches
Mail list logo
