Zren added a comment.
Yes I do. Sorry I didn't get to push it yesterday. Thanks for approving the
change!
Hmm, it seems the bot didn't recognize "Bug: 388553" in the commit message.
Looks like I need to remember to use all caps next time "BUG: 388553".
REPOSITORY
R115 Plasma Audio
drosca added a comment.
Do you have dev account?
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D9726
To: Zren, #plasma, drosca
Cc: drosca, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
drosca accepted this revision.
drosca added a comment.
This revision is now accepted and ready to land.
Alright, thanks for the writeup.
REPOSITORY
R115 Plasma Audio Volume Applet
REVISION DETAIL
https://phabricator.kde.org/D9726
To: Zren, #plasma, drosca
Cc: drosca, plasma-devel,
Zren added a comment.
> one channel is 0%, second is 100% and merged volume now shows 100%
If you lower the volume on a speaker, you care more about what the volume of
the louder speaker is. It's weird if the OSD shows 50% when the right speaker
is blaring at 100% and annoying my
drosca added a comment.
Well, this was actually intended to work like that. In case of split
channels, I would say "avg" describes the merged volume better than "max",
because with "max" you can have situation where one channel is 0%, second is
100% and merged volume now shows 100% which is
Zren created this revision.
Zren added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Zren requested review of this revision.
REVISION SUMMARY
When we use the avg, it's very easy to "boost" the "right speaker" over
