D9762: [Image Wallpaper] Just use Timer to determin when we're ready

2019-02-17 Thread M. Vefa Bicakci
bicakci added a comment. Hello! This commit causes a regression on my system. [1] In summary, during plasma's start-up the desktop background/wallpaper is initially displayed, but as soon as kscreen sets up the displays there are a number of flickers and the wallpaper is replaced with

D9762: [Image Wallpaper] Just use Timer to determin when we're ready

2018-01-15 Thread Kai Uwe Broulik
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R120:87ec46be03b4: [Image Wallpaper] Just use Timer to determin when were ready (authored by broulik). REPOSITORY R120

D9762: [Image Wallpaper] Just use Timer to determin when we're ready

2018-01-12 Thread Kai Uwe Broulik
broulik updated this revision to Diff 25235. broulik added a comment. Restore source size check before fading it REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9762?vs=25017=25235 REVISION DETAIL https://phabricator.kde.org/D9762 AFFECTED

D9762: [Image Wallpaper] Just use Timer to determin when we're ready

2018-01-09 Thread David Edmundson
davidedmundson added a comment. Meh. If there's nothing by 5.12.0 push it, but hopefully we can get something better by then. At a glance, I'd assume it's failing because onFillModelChanged and onModelChanged are both called during startup resulting in the second one doing a fade?

D9762: [Image Wallpaper] Just use Timer to determin when we're ready

2018-01-09 Thread Kai Uwe Broulik
broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D9762 To: broulik, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9762: [Image Wallpaper] Just use Timer to determin when we're ready

2018-01-09 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This avoids fading the image source, or the fill mode, or the