D9786: [Kickoff] Fix RTL issues

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b127e545b552: [Kickoff] Fix RTL issues (authored by safaalfulaij). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25384&id=25386 REVISION DETAIL h

D9786: [Kickoff] Fix RTL issues

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalfulaij, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensr

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25384. safaalfulaij added a comment. - 0 instead of undefined - change statments order REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25138&id=25384 BRANCH master REVISION DETAIL https://phab

D9786: [Kickoff] Fix RTL issues

broulik added a comment. Looking good! INLINE COMMENTS > ApplicationsView.qml:112 > +// HACK: Align the content to right for RTL locales > +leftMargin: LayoutMirroring.enabled ? Math.max(0, width - > contentWidth) : undefined > + `leftMargin` does not have a `RESET`

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25138. safaalfulaij added a comment. - Align header labels to left REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25137&id=25138 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786

D9786: [Kickoff] Fix RTL issues

safaalfulaij updated this revision to Diff 25137. safaalfulaij added a comment. - Just align it correctly REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9786?vs=25073&id=25137 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9786 AFF

D9786: [Kickoff] Fix RTL issues

broulik added a comment. Perhaps you could manually set `contentX` to an appropriate value after adding a breadcrumb. I think the issue is that `Flickable` internally is still left-aligned, so I would suggest meddling around with `contentX` REPOSITORY R119 Plasma Desktop REVISION DETAIL

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. In https://phabricator.kde.org/D9786#188720, @broulik wrote: > I see. > > How about playing with `leftMargin` of the `Flickable` to right-align it? Something along the lines of > > leftMargin: Math.max(0, width - contentWidth) > Well, that

D9786: [Kickoff] Fix RTL issues

broulik added a comment. I see. How about playing with `leftMargin` of the `Flickable` to right-align it? Something along the lines of leftMargin: Math.max(0, width - contentWidth) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalful

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. I'll answer that here to put some visuals. This is before the patch, all fine, correct direction, but aligned to left: F5633510: step 1.png Here we mirror the graphics of the Flickable: F5633511: step 2.png

D9786: [Kickoff] Fix RTL issues

broulik added inline comments. INLINE COMMENTS > ApplicationsView.qml:127 > depth: 0 > +scale: LayoutMirroring.enabled ? -1 : 1 // Mirror the > already mirrored item back > } Where is it "already mirrored"? I think we're just hiding a di

D9786: [Kickoff] Fix RTL issues

safaalfulaij added a comment. After applying: F5633478: kickoff_after.mp4 Sorry couldn't crop video REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9786 To: safaalfulaij, #plasma Cc: plasma-devel, ZrenBot, progw

D9786: [Kickoff] Fix RTL issues

safaalfulaij created this revision. safaalfulaij added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. safaalfulaij requested review of this revision. REVISION SUMMARY Fix 2 issues: - the breadcrumbs alignment -