D9803: Apply some C++11 niceties, styling consistency

Kanedias closed this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9803: Apply some C++11 niceties, styling consistency

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH c++11 REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreut

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25244. Kanedias added a comment. Rebased REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25198&id=25244 BRANCH c++11 REVISION DETAIL https://phabricator.kde.org/D9803 AFFECTED F

D9803: Apply some C++11 niceties, styling consistency

Kanedias added a comment. Will update this today with changes from caching by Alex REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9803: Apply some C++11 niceties, styling consistency

Kanedias marked 3 inline comments as done. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: apol, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25198. Kanedias added a comment. Fix palette array allocation REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25123&id=25198 BRANCH c++11 REVISION DETAIL https://phabricator.kde.

D9803: Apply some C++11 niceties, styling consistency

apol added inline comments. INLINE COMMENTS > Kanedias wrote in plasmadesktoptheme.cpp:160 > I didn't quite get it, you mean we can write `for (auto state : { > QPalette::Active, QPalette::Inactive, QPalette::Disabled })` to get rid of > allocation of `states` array? Yes, or `static const auto

D9803: Apply some C++11 niceties, styling consistency

Kanedias added inline comments. INLINE COMMENTS > apol wrote in plasmadesktoptheme.cpp:160 > if you make it `auto` the initializer_list will be used not requiring the > allocation AFAIU. > That said, I wonder if the compiler can unwind a foreach. I didn't quite get it, you mean we can write `fo

D9803: Apply some C++11 niceties, styling consistency

apol added inline comments. INLINE COMMENTS > plasmadesktoptheme.cpp:160 > QPalette pal = palette(); > static const QPalette::ColorGroup states[3] = { QPalette::Active, > QPalette::Inactive, QPalette::Disabled }; > +for (auto state : states) { if you make it `auto` the initializer

D9803: Apply some C++11 niceties, styling consistency

Kanedias edited the summary of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias updated this revision to Diff 25123. Kanedias added a comment. Apply some C++11 niceties, styling consistency REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9803?vs=25122&id=25123 BRANCH master REVISION DETAIL https

D9803: Apply some C++11 niceties, styling consistency

Kanedias added a reviewer: mart. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D9803 To: Kanedias, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9803: Apply some C++11 niceties, styling consistency

Kanedias created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Kanedias requested review of this revision. REPOSITORY R858 Qt Quick Controls 2: Desktop Style BRANCH master REVISION DETAIL https://phabricator.kde.org/