Extender theming issues.

2008-10-09 Thread Rob Scheepmaker
Hello everyone. As you might have noticed, I've added support for theming the background of extenderitems through a standard panelSvg svg in the desktoptheme. While this is certainly an improvement over not having a background at all, it's still not as neat as I would like it to be. Notice this

Re: Extender theming issues.

2008-10-09 Thread Aaron J. Seigo
On Thursday 09 October 2008, Rob Scheepmaker wrote: > The problem occurs when we would like to keep this same look when the > extender is contained in an applet on the desktop, which is currently the the Applets-with-extenders shown in the mockup are flawed: they do not have the same divider betw

Re: Extender theming issues.

2008-10-09 Thread Marco Martin
On Thursday 09 October 2008, Rob Scheepmaker wrote: > Hello everyone. > > As you might have noticed, I've added support for theming the background of > extenderitems through a standard panelSvg svg in the desktoptheme. While > this is certainly an improvement over not having a background at all, it

Re: Extender theming issues.

2008-10-09 Thread Sebastian Kügler
On Thursday 09 October 2008 18:07:35 Aaron J. Seigo wrote: > for now, i'd be just fine with skipping that issue altogether until we have > some actual real world examples of this in action beyond the custom > internal extender applet, where we can afford to invest a bit of custom > effort (e.g. set

Re: Extender theming issues.

2008-10-09 Thread Aaron J. Seigo
On Thursday 09 October 2008, Sebastian Kügler wrote: > On Thursday 09 October 2008 18:07:35 Aaron J. Seigo wrote: > > for now, i'd be just fine with skipping that issue altogether until we > > have some actual real world examples of this in action beyond the custom > > internal extender applet, whe

Re: Extender theming issues.

2008-10-09 Thread Sebastian Kügler
On Thursday 09 October 2008 20:47:29 Aaron J. Seigo wrote: > On Thursday 09 October 2008, Sebastian Kügler wrote: > > On Thursday 09 October 2008 18:07:35 Aaron J. Seigo wrote: > > > for now, i'd be just fine with skipping that issue altogether until we > > > have some actual real world examples of

Re: Extender theming issues.

2008-10-09 Thread pinheiro
A Thursday 09 October 2008 17:07:35, Aaron J. Seigo escreveu: > On Thursday 09 October 2008, Rob Scheepmaker wrote: > > The problem occurs when we would like to keep this same look when the > > extender is contained in an applet on the desktop, which is currently the > > the Applets-with-extenders

Re: Extender theming issues.

2008-10-09 Thread Aaron J. Seigo
On Thursday 09 October 2008, Sebastian Kügler wrote: > > is the battery doing it's own layout there, or is it just relying on > > PopupApplet to be doing the right thing? > > Battery puts a QGridLayout inside the extender. well, yes. but it doesn't manage the extender itself. PopupApplet::graphic

Re: Extender theming issues.

2008-10-09 Thread Rob Scheepmaker
On Thursday 09 October 2008 21:28:32 Aaron J. Seigo wrote: > well, yes. but it doesn't manage the extender itself. > PopupApplet::graphicsWidget() returns the extender on behalf of the Battery > applet. > > therefore, the place to manage that use case is inside of PopoupApplet > itself as well. if

Re: Extender theming issues.

2008-10-09 Thread Aaron J. Seigo
On Thursday 09 October 2008, Rob Scheepmaker wrote: > The margins contained in the panelSvg leave a gap between the borders of > the extenderItem and the border of the applet background, setting the > margin to 0 makes the borders of the extenderItem stick out of the applet > border. Either way, th

Re: Extender theming issues.

2008-10-09 Thread Rob Scheepmaker
On Thursday 09 October 2008 18:51:15 Marco Martin wrote: > On Thursday 09 October 2008, Rob Scheepmaker wrote: > > Hello everyone. > > > > As you might have noticed, I've added support for theming the background > > of extenderitems through a standard panelSvg svg in the desktoptheme. > > While thi

Re: Extender theming issues.

2008-10-09 Thread Rob Scheepmaker
On Thursday 09 October 2008 22:51:37 Aaron J. Seigo wrote: > On Thursday 09 October 2008, Rob Scheepmaker wrote: > > The margins contained in the panelSvg leave a gap between the borders of > > the extenderItem and the border of the applet background, setting the > > margin to 0 makes the borders o

Re: Extender theming issues.

2008-10-09 Thread Aaron J. Seigo
On Thursday 09 October 2008, Rob Scheepmaker wrote: > On Thursday 09 October 2008 22:51:37 Aaron J. Seigo wrote: > > On Thursday 09 October 2008, Rob Scheepmaker wrote: > > > The margins contained in the panelSvg leave a gap between the borders > > > of the extenderItem and the border of the applet

Re: Extender theming issues.

2008-10-10 Thread Marco Martin
On Friday 10 October 2008, Rob Scheepmaker wrote: > On Friday 10 October 2008 00:01:15 Aaron J. Seigo wrote: > > ah, i see .. i wasn't explicit enough: keep the top margin in the dialog, > > just get rid of the left/right/bottom margins. > > > > the reason for doing it this way is then you don't ha

Re: Extender theming issues.

2008-10-10 Thread Rob Scheepmaker
On Friday 10 October 2008 14:48:05 Marco Martin wrote: > On Friday 10 October 2008, Rob Scheepmaker wrote: > > On Friday 10 October 2008 00:01:15 Aaron J. Seigo wrote: > > > ah, i see .. i wasn't explicit enough: keep the top margin in the > > > dialog, just get rid of the left/right/bottom margins

Re: Extender theming issues.

2008-10-10 Thread Marco Martin
On Friday 10 October 2008, Rob Scheepmaker wrote: > On Friday 10 October 2008 14:48:05 Marco Martin wrote: > > On Friday 10 October 2008, Rob Scheepmaker wrote: > > > On Friday 10 October 2008 00:01:15 Aaron J. Seigo wrote: > > > > ah, i see .. i wasn't explicit enough: keep the top margin in the >

Re: Extender theming issues.

2008-10-10 Thread Rob Scheepmaker
On Friday 10 October 2008 00:01:15 Aaron J. Seigo wrote: > ah, i see .. i wasn't explicit enough: keep the top margin in the dialog, > just get rid of the left/right/bottom margins. > > the reason for doing it this way is then you don't have to specia case > anything when the Extender gets used in

Re: Extender theming issues.

2008-10-10 Thread Rob Scheepmaker
On Thursday 09 October 2008 21:14:05 pinheiro wrote: > A Thursday 09 October 2008 17:07:35, Aaron J. Seigo escreveu: > > the Applets-with-extenders shown in the mockup are flawed: they do not > > have the same divider between the items (e.g. Grab and Grab 2) that they > > do in the dialogs. > > wen

Re: Extender theming issues.

2008-10-10 Thread pinheiro
A Friday 10 October 2008 12:29:50, Rob Scheepmaker escreveu: > On Thursday 09 October 2008 21:14:05 pinheiro wrote: > > A Thursday 09 October 2008 17:07:35, Aaron J. Seigo escreveu: > > > the Applets-with-extenders shown in the mockup are flawed: they do not > > > have the same divider between the

Re: Extender theming issues.

2008-10-10 Thread Aaron J. Seigo
On Friday 10 October 2008, Marco Martin wrote: > what about: the extender items paints their own background, > if an applet has an extender with items and nothing else the standard > background is off, if has also some other things extender items are shown > outside the main layout, attached as an

Re: Extender theming issues.

2008-10-10 Thread Aaron J. Seigo
On Friday 10 October 2008, Marco Martin wrote: > not exactly: the problem is that there must be two different dialog svgs: > one loaded when the desktop effects are on and that is exactly the same as > applet (but nothing forbid a theme to make two totally different ones) and > one loaded when effe

Re: Extender theming issues.

2008-10-10 Thread Rob Scheepmaker
On Friday 10 October 2008 19:50:39 Aaron J. Seigo wrote: > On Friday 10 October 2008, Marco Martin wrote: > > not exactly: the problem is that there must be two different dialog svgs: > > one loaded when the desktop effects are on and that is exactly the same > > as applet (but nothing forbid a the

Re: Extender theming issues.

2008-10-10 Thread Marco Martin
On Friday 10 October 2008, Aaron J. Seigo wrote: > On Friday 10 October 2008, Marco Martin wrote: > > not exactly: the problem is that there must be two different dialog svgs: > > one loaded when the desktop effects are on and that is exactly the same > > as applet (but nothing forbid a theme to ma