KDE/kdelibs/plasma

2011-01-16 Thread Aaron J . Seigo
CCMAIL:plasma-devel@kde.org M +37 -0 querymatch.cpp --- trunk/KDE/kdelibs/plasma/querymatch.cpp #1214925:1214926 @@ -21,6 +21,7 @@ #include #include +#include #include #include #include @@ -38,6 +39,7 @@ public: QueryMatchPrivate(AbstractRunner *r

Re: KDE/kdelibs/plasma

2010-11-14 Thread Aaron J. Seigo
On Sunday, November 14, 2010, Chani wrote: > > > breaks creation of new activities that aren't from templates :) > > > either give me a different method that plasmaapp can use, or revert > > > that line. > > > > whatever code is doing that is broken. that it worked at all was an > > accident of Co

KDE/kdelibs/plasma

2010-10-14 Thread Aaron J . Seigo
svg.h --- trunk/KDE/kdelibs/plasma/framesvg.cpp #1185855:1185856 @@ -1,6 +1,6 @@ /* - * Copyright 2008 by Aaron Seigo - * Copyright 2008 Marco Martin + * Copyright 2008-2010 by Aaron Seigo + * Copyright 2008-2010 Marco Martin * * This program is free software; you can

Re: KDE/kdelibs/plasma

2010-08-17 Thread Brian Pritchett
ServiceJob* retrieveJob = > > d->store->startOperationCall(retrieveGroup); > > > > connect(retrieveJob, SIGNAL(result(KJob*)), this, > > > > SLOT(populateFromStoredData(KJob*))); > > > > } > > > >

Re: KDE/kdelibs/plasma

2010-08-17 Thread laurent Montel
y].toString().toAscii()); QDataStream ds(&b, > QIODevice::ReadOnly); > QVariant v(ds); > key.remove(0, 7); > dataToInsert.insert(key, v); > -} else { > -dataToInsert.insert(key, h[key]); > } > -} &g

Re: KDE/kdelibs/plasma

2010-07-30 Thread Aaron J. Seigo
On July 30, 2010, Marco Martin wrote: > SVN commit 1157180 by mart: > > support load by plugin from AbstractToolBox it's missing a static KPluginInfo::List listToolBoxInfo(const QString &parentApp = QString()) method, to follow the pattern of the others. > could be the case to add it to PluginL

KDE/kdelibs/plasma

2010-07-30 Thread Marco Martin
--- trunk/KDE/kdelibs/plasma/corona.cpp #1157189:1157190 @@ -279,6 +279,7 @@ KShortcutsDialog shortcutsDlg; QMap containmentActionsDefaults; QWeakPointerdialogManager; +QHash toolBoxPlugins; }; bool CoronaPrivate::s_positioningContainments = false; @@ -796,6 +797,17

KDE/kdelibs/plasma

2010-07-30 Thread Marco Martin
M +33 -0 abstracttoolbox.cpp M +20 -0 abstracttoolbox.h A data/servicetypes/plasma-toolbox.desktop --- trunk/KDE/kdelibs/plasma/CMakeLists.txt #1157179:1157180 @@ -408,6 +408,7 @@ data/servicetypes/plasma-packagestructure.desktop data/servicetypes/p

Re: KDE/kdelibs/plasma/animations

2010-02-02 Thread Bruno Abinader
ight) and added support for combinations (i.e. MoveUp|MoveLeft). >> Currently used by RotationStacked and Slide animations, which were >> previously adapted to this clean design >> >> >>  M  +10 -15    animation.h >> >> >> --- trunk/KDE

Re: KDE/kdelibs/plasma/animations

2010-02-01 Thread Aaron J. Seigo
acked and Slide animations, which were > previously adapted to this clean design > > > M +10 -15animation.h > > > --- trunk/KDE/kdelibs/plasma/animations/animation.h #1083640:1083641 > @@ -65,28 +65,23 @@ > */ > enum Reference { > Center = 0,

KDE/kdelibs/plasma

2009-12-29 Thread Chani Armitage
is. M +10 -10 containment.cpp --- trunk/KDE/kdelibs/plasma/containment.cpp #1067595:1067596 @@ -1639,16 +1639,6 @@ return; //no unexpected click-throughs } -QString trigger = ContainmentActions::eventToString(event); - -if (d->actionPlugins.contains(trigger)) { -if

Re: KDE/kdelibs/plasma/extenders

2009-11-10 Thread Chani
On November 10, 2009 13:03:58 Aaron J. Seigo wrote: > On November 10, 2009, Marco Martin wrote: > > SVN commit 1047062 by mart: > > > > emit a signal when the user clicks the close button. > > would perhaps be better to bind it with an action and make it accessible > > with action("close")? > > ye

Re: KDE/kdelibs/plasma/extenders

2009-11-10 Thread Aaron J. Seigo
On November 10, 2009, Marco Martin wrote: > SVN commit 1047062 by mart: > > emit a signal when the user clicks the close button. > would perhaps be better to bind it with an action and make it accessible > with action("close")? yes, i think so. it would allow disabling it, triggering it, and othe

KDE/kdelibs/plasma/extenders

2009-11-10 Thread Marco Martin
ts/configuration-icons", "close"); QSizeF size = destroyAction->sizeFromIconSize(iconSize); destroyAction->setMinimumSize(size); --- trunk/KDE/kdelibs/plasma/extenders/extenderitem.h #1047061:1047062 @@ -254,6 +254,15 @@ */ void hideClo

KDE/kdelibs/plasma/widgets

2009-10-02 Thread Marco Martin
l.cpp M +1 -0 label.h --- trunk/KDE/kdelibs/plasma/widgets/label.cpp #1030633:1030634 @@ -19,6 +19,7 @@ #include "label.h" +#include #include #include #include @@ -293,7 +294,7 @@ void Label::changeEvent(QEvent *event) { -if (event->type() == QEvent::Fon

KDE/kdelibs/plasma/widgets

2009-09-24 Thread Marco Martin
+42 -1 scrollwidget.cpp M +8 -0 scrollwidget.h --- trunk/KDE/kdelibs/plasma/widgets/scrollwidget.cpp #1027813:1027814 @@ -32,6 +32,7 @@ //Plasma #include #include +#include #include namespace Plasma @@ -47,7 +48,8 @@ bottomBorder(0), leftBorder(0

KDE/kdelibs/plasma/widgets

2009-09-02 Thread Marco Martin
SVN commit 1019013 by mart: add tabAt(int) function actually the correspondent qtabwidget is widget(), but on a qgraphicsproxywidget it is taken, maybe needs a beter name? CCMAIL: plasma-devel@kde.org M +19 -0 tabbar.cpp M +8 -0 tabbar.h --- trunk/KDE/kdelibs/plasma/widgets

KDE/kdelibs/plasma

2009-08-08 Thread Sebastian Kügler
o marco for reviewing and everybody else for the input :) Next steps are making some more applets work with this. CCMAIL:plasma-devel@kde.org M +102 -11 containment.cpp M +11 -1 containment.h M +4 -0 private/containment_p.h --- trunk/KDE/kdelibs/plasma/containment.

Re: KDE/kdelibs/plasma

2009-07-09 Thread Marco Martin
On 7/9/09, Richard Moore wrote: > On Wed, Jul 8, 2009 at 3:56 PM, Marco Martin wrote: >> +ItemStatus status(); > > Const! i was soo tired, i swear! :) > Rich. > ___ > Plasma-devel mailing list > Plasma-devel@kde.org > https://mail.kde.org/mailman/

Re: KDE/kdelibs/plasma

2009-07-08 Thread Richard Moore
On Wed, Jul 8, 2009 at 3:56 PM, Marco Martin wrote: > +ItemStatus status(); Const! Rich. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: KDE/kdelibs/plasma

2009-07-08 Thread Aaron J. Seigo
On Wednesday 08 July 2009, Marco Martin wrote: > On 7/8/09, Aaron J. Seigo wrote: > > On Wednesday 08 July 2009, Marco Martin wrote: > >> api to show/hide plasmoids from the systray, like NotificationItems > >> > >> +UnknownStatus = 0, > >> +PassiveStatus = 1, > >> +ActiveStatus = 2, >

Re: KDE/kdelibs/plasma

2009-07-08 Thread Marco Martin
On 7/8/09, Aaron J. Seigo wrote: > On Wednesday 08 July 2009, Marco Martin wrote: >> api to show/hide plasmoids from the systray, like NotificationItems > >> +UnknownStatus = 0, >> +PassiveStatus = 1, >> +ActiveStatus = 2, >> +NeedsAttentionStatus = 3 > > * forget about systray; th

Re: KDE/kdelibs/plasma

2009-07-08 Thread Aaron J. Seigo
On Wednesday 08 July 2009, Marco Martin wrote: > api to show/hide plasmoids from the systray, like NotificationItems > +UnknownStatus = 0, > +PassiveStatus = 1, > +ActiveStatus = 2, > +NeedsAttentionStatus = 3 * forget about systray; that's a use case, but isn't the only one. we h

KDE/kdelibs/plasma

2009-07-08 Thread Marco Martin
/KDE/kdelibs/plasma/plasma.h #993363:993364 @@ -250,6 +250,17 @@ }; Q_DECLARE_FLAGS(MessageButtons, MessageButton) +/** + * Status of an applet... + * FIXME: this will have to move in PopupApplet? or find an api-less way? + */ +enum ItemStatus { +UnknownStatus = 0, +PassiveStatus = 1

Re: KDE/kdelibs/plasma

2009-06-30 Thread Aaron J. Seigo
On Tuesday 30 June 2009, Marco Martin wrote: > allow applet configuration and extenderitems config nested into the > group of another applet > this thing is possibly dangerous, so better plasma-devel is informed could probably get rid of a hack in the systemmonitor related to configuration now wi

KDE/kdelibs/plasma

2009-06-30 Thread Marco Martin
parentApplet != q->containment()) { +appletConfig = KConfigGroup(&parentApplet->config(), "Applets"); +} else if (q->containment()) { appletConfig = q->containment()->config(); appletConfig = KConfigGroup(&appletC

KDE/kdelibs/plasma

2009-06-25 Thread Aaron J . Seigo
SVN commit 987462 by aseigo: clickable tooltips; plasma-devel@ people: please review API one more time CCMAIL:plasma-devel@kde.org M +77 -34private/tooltip.cpp M +12 -0 private/tooltip_p.h M +19 -1 private/windowpreview.cpp M +4 -0 private/windowpreview_p.h M +

Re: KDE/kdelibs/plasma

2009-05-01 Thread Aaron J. Seigo
On Thursday 30 April 2009, Aaron J. Seigo wrote: > On Thursday 30 April 2009, David Nolden wrote: > > SVN commit 961915 by zwabel: > > > > - Allow painting a background color, or a background pattern behind > > freely floating elements of the theme, to provide a better fallback > > mechanism for tr

Re: KDE/kdelibs/plasma

2009-04-30 Thread Aaron J. Seigo
On Thursday 30 April 2009, David Nolden wrote: > SVN commit 961915 by zwabel: > > - Allow painting a background color, or a background pattern behind freely > floating elements of the theme, to provide a better fallback mechanism for > transparent themes when composition is not available. The color

Re: KDE/kdelibs/plasma/widgets

2009-02-09 Thread Aaron J. Seigo
On Monday 09 February 2009, Marco Martin wrote: > this is an open question: i'm asking to everybody: opinions how it should > be? i don't think the scripting stuff needs anything in the media objects, so they don't need to be exposed, nor wrapped further, for them. -- Aaron J. Seigo humru othro

Re: KDE/kdelibs/plasma/widgets

2009-02-09 Thread Marco Martin
On 2/9/09, Dan Meltzer wrote: > On Mon, Feb 9, 2009 at 11:09 AM, Marco Martin wrote: >> SVN commit 923865 by mart: >> >> a bit of comments doesn't hurt > (Yay, random api review based on comments!) > > >> >> >> M +48 -2 videow

Re: KDE/kdelibs/plasma/widgets

2009-02-09 Thread Dan Meltzer
On Mon, Feb 9, 2009 at 11:09 AM, Marco Martin wrote: > SVN commit 923865 by mart: > > a bit of comments doesn't hurt (Yay, random api review based on comments!) > > > M +48 -2 videowidget.h > > > --- trunk/KDE/kdelibs/plasma/widgets/videowidget.h

Re: KDE/kdelibs/plasma

2009-01-28 Thread David Faure
On Wednesday 28 January 2009, Dan Meltzer wrote: > On Tue, Jan 27, 2009 at 7:12 PM, Christophe Giboudeaux > wrote: > > SVN commit 917529 by cgiboudeaux: > > > > kaction.h is already included. Just remove the extra ones > > Would it make sense, in terms of visual helpers--to not use camelcase > fo

Re: KDE/kdelibs/plasma

2009-01-27 Thread Dan Meltzer
t; M +0 -1 containment.cpp > > > --- trunk/KDE/kdelibs/plasma/applet.cpp #917528:917529 > @@ -25,7 +25,6 @@ > #include > #include > > -#include > #include > #include > #include > --- trunk/KDE/kdelibs/plasma/containment.cpp #917528:917529

KDE/kdelibs/plasma

2009-01-22 Thread Aaron J . Seigo
SVN commit 915488 by aseigo: a lot less popup flickering and repainting. if there are no sideeffects to this discovered, this needs to be backported to the 4.2 branch. CCMAIL:plasma-devel@kde.org M +39 -30dialog.cpp M +8 -9 popupapplet.cpp --- trunk/KDE/kdelibs/plasma