Re: [Kourse 3] Fixing krazy2 issues

On Friday 16 January 2009, Philipp Klaffert wrote: > Thank you for commiting the patch!! thanks for putting the effort into writing it =) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software s

Re: [Kourse 3] Fixing krazy2 issues

Am 16. Januar 2009 00:21 schrieb Aaron J. Seigo : > On Thursday 15 January 2009, Philipp Klaffert wrote: > > I've now swapped all the Strings with constants and so, just 3 objects an > > no more krazy complaining for at least these issues. > > great; ready to commit! =)) > > -- > Aaron J. Seigo >

Re: [Kourse 3] Fixing krazy2 issues

On Thursday 15 January 2009, Philipp Klaffert wrote: > I've now swapped all the Strings with constants and so, just 3 objects an > no more krazy complaining for at least these issues. great; ready to commit! =)) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA

Re: [Kourse 3] Fixing krazy2 issues

Am 15. Januar 2009 17:39 schrieb Aaron J. Seigo : > On Thursday 15 January 2009, Philipp Klaffert wrote: > > thanks for your reply and for the link. For fixing the krazy2 issues > > correctly I changed QString to QLatin1String. I understand your point of > > view with "readability" but I won't dec

Re: [Kourse 3] Fixing krazy2 issues

On Thursday 15 January 2009, Philipp Klaffert wrote: > thanks for your reply and for the link. For fixing the krazy2 issues > correctly I changed QString to QLatin1String. I understand your point of > view with "readability" but I won't decide which way is better. I think the > explicit conversion

Re: [Kourse 3] Fixing krazy2 issues

Hi Dominik, thanks for your reply and for the link. For fixing the krazy2 issues correctly I changed QString to QLatin1String. I understand your point of view with "readability" but I won't decide which way is better. I think the explicit conversion of these Strings makes the understanding of the

Re: [Kourse 3] Fixing krazy2 issues

Hi Philipp, On Thursday 15 January 2009, Philipp Klaffert wrote: > @@ -54,7 +53,7 @@ > return true; > } > > -if (!name.startsWith("Timeline:") && > !name.startsWith("TimelineWithFriends:") && > !name.startsWith("Profile:")) { > +if > (!name.startsWith(QString("Timeline:"))

RE: [Kourse 3] Fixing krazy2 issues

> Hey > 2009/1/15 Philipp Klaffert >: >*> license and copyright issues and you can find the patch in the attachement *>*> of this Mail. * > I think you forgot to attach the patch hehe =) > Cheers and I think you are right... :) Index: dataengi