Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

On Monday, July 21, 2014 19:07:52 Martin Gräßlin wrote: > On Monday 21 July 2014 16:40:48 David Edmundson wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > https://git.reviewboard.kde.org/r/119330/ > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

On Monday 21 July 2014 16:40:48 David Edmundson wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119330/ > --- > > (Updated

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 21, 2014, 4:40 p.m.) Status -- This change has been ma

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 4:26 p.m., Marco Martin wrote: > > src/plasma/framesvg.cpp, line 480 > > > > > > are you sure about this one? > > doesn't contentGeometry returns the rectangle adjusted only by frame > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62799 --- Ship it! yes, that :p still an issue below I'm unsure of.

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 21, 2014, 4:04 p.m.) Review request for Plasma. Changes -

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 2:09 p.m., Marco Martin wrote: > > src/plasma/framesvg.h, line 290 > > > > > > err, it's not really how I intended in the previous review.. adding > > public api is even worse... > > > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 2:09 p.m., Marco Martin wrote: > > It is possible to have neither private objects exported, neither public api > > added. Yes, it duplicates a bit of the implementation, but I rather prefer > > it a lot than either adding api or exporting private symbols. It's possible to d

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 21, 2014, 2:09 p.m., Marco Martin wrote: > > src/plasma/framesvg.h, line 290 > > > > > > err, it's not really how I intended in the previous review.. adding > > public api is even worse... > > > >

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62788 --- It is possible to have neither private objects exported, neith

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 21, 2014, 1:51 p.m.) Review request for Plasma. Repositor

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 18, 2014, 11:58 a.m., Marco Martin wrote: > > framesvgitem part starting to look good! > > I would still like to have all of framesvg private again tough > > Aleix Pol Gonzalez wrote: > Can you ellaborate on what don't you like about the approach? > We're not installing headers

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 18, 2014, 11:58 a.m., Marco Martin wrote: > > framesvgitem part starting to look good! > > I would still like to have all of framesvg private again tough Can you ellaborate on what don't you like about the approach? We're not installing headers, so we don't need to maintain ABI there.

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62651 --- framesvgitem part starting to look good! I would still like to

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 18, 2014, 10:54 a.m.) Review request for Plasma. Changes

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 17, 2014, 11:21 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.h, line 171 > > > > > > We probably don't want these 2 public. Edit: this whole class is not exported and we us

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/ --- (Updated July 17, 2014, 8:44 p.m.) Review request for Plasma. Changes -

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 17, 2014, 11:33 a.m., Marco Martin wrote: > > no, this branch is not good to go. > > > > * all the commits to framesvg.h/.cpp shouldn't be there at all. > > * the sub-pixmaps fetched from svg->image() will be correct only in a > > single case, of no composeoverborders and no overlays

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

> On July 17, 2014, 11:33 a.m., Marco Martin wrote: > > no, this branch is not good to go. > > > > * all the commits to framesvg.h/.cpp shouldn't be there at all. > > * the sub-pixmaps fetched from svg->image() will be correct only in a > > single case, of no composeoverborders and no overlays

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62571 --- no, this branch is not good to go. * all the commits to frame

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62567 --- src/declarativeimports/core/framesvgitem.h

Re: Review Request 119330: Convert FrameSvgItem to use 9 tiles instead of a big texture.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119330/#review62566 --- Besides the development, I've been using it with my plasma, it