Re: Request for review

2014-02-17 Thread Martin Klapetek
On Mon, Feb 17, 2014 at 8:01 AM, Conny Marco Menebröcker ad...@menebroecker-web.de wrote: I will read the tutorial and decide afterwards, if I will change something. I don't know much about QML, I thought it was only a specific programming language for QT development. So, currently I don't

Re: Request for review

2014-02-16 Thread Martin Klapetek
Hey, -- Forwarded message -- From: Conny Marco Menebröcker ad...@menebroecker-web.de Date: Sat, Feb 15, 2014 at 7:44 PM Subject: Request for review To: kde-de...@kde.org Hello all, I have written my first plasmoid. I called it PlasmaTaskViewer, because it views

Re: Request for review

2014-02-16 Thread Conny Marco Menebröcker
Hello Martin, Am 16.02.2014 17:41, schrieb Martin Klapetek: Hey, -- Forwarded message -- From: Conny Marco Menebröcker ad...@menebroecker-web.de mailto:ad...@menebroecker-web.de Date: Sat, Feb 15, 2014 at 7:44 PM Subject: Request for review To: kde-de

Fwd: Request for review

2014-02-15 Thread Myriam Schweingruber
FYI, I guess the plasma development mailing list is more likely to look at review request for a plasmoid... Regards, Myriam -- Forwarded message -- From: Conny Marco Menebröcker ad...@menebroecker-web.de Date: Sat, Feb 15, 2014 at 7:44 PM Subject: Request for review To: kde-de

Re: request for review

2012-03-19 Thread Sebastian Kügler
a formal review request if that makes things easier. i will do so later for the non-merged duckduckgo runner, so as to not repeat the same mistake. but the only things of interest here are the youtube and bing runners. the bing one is the same exact thing, except for bing obviously. https

Re: Re: request for review

2012-03-19 Thread Alex Fiestas
On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote: Hey, One potential issue I see is that you ship the youtube logo inside the runner. We might not be allowed to redistribute it as that. It also scales badly, so looks visually tarred. Can you check the license of the youtube

Re: request for review

2012-03-19 Thread Aaron J. Seigo
On Monday, March 19, 2012 11:33:13 Alex Fiestas wrote: In theory they will only be triggered if the prefix match, kinda youtube: kde rocks this is easy for the runner itself to do. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part.

Re: Re: request for review

2012-03-19 Thread Shaun Reich
On Mon, Mar 19, 2012 at 6:33 AM, Alex Fiestas afies...@kde.org wrote: On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote: Hey, One potential issue I see is that you ship the youtube logo inside the runner. We might not be allowed to redistribute it as that. It also scales badly,

Re: request for review

2012-03-19 Thread Shaun Reich
On Mon, Mar 19, 2012 at 6:28 AM, Sebastian Kügler se...@kde.org wrote: (Positive, because it works, negative, because I might have been looking for my furry porn collection, not something I'd want to tell any web services.) yeah, good point. i don't want google knowing i'm into furry porn

request for review

2012-03-16 Thread Shaun Reich
the feathers ;-) i can file a formal review request if that makes things easier. i will do so later for the non-merged duckduckgo runner, so as to not repeat the same mistake. but the only things of interest here are the youtube and bing runners. the bing one is the same exact thing, except

Re: request for review

2012-03-16 Thread Aaron J. Seigo
On Friday, March 16, 2012 13:10:54 Shaun Reich wrote: i do have a question however, as to why matches get triggered (even for the mediawiki engine which currently resides in there, afict), even though it isn't in singlerunnermode, and the prefix isn't being hit. e.g. user is typing in some

Re: request for review

2012-03-16 Thread Shaun Reich
.. assuming i'm understanding what you're asking :) yep, answers exactly that. -- Shaun Reich, KDE Software Developer (kde.org) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Code review for the newspaper containment

2011-06-20 Thread Aaron J. Seigo
p.m.) Review request for Plasma. Summary --- While tracking down some problems in the Newspaper containment problems I decided to simplify a little its code. I think this makes it a little more readable. Hope that helps. Diffs - plasma/containments/newspaper

Review Request: Code review for the newspaper containment

2011-06-08 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101543/ --- Review request for Plasma. Summary --- While tracking down some