Re: Review Request: Activate present windows from task group context menu

2009-07-15 Thread Martin Gräßlin
Am Samstag 27 Juni 2009 19:42:58 schrieb Aaron J. Seigo: > On Saturday 27 June 2009, Martin Gräßlin wrote: > > I like the idea of replacing the menu of the task group. It's kind of > > consistent: clicking on a task item will raise the window, clicking on a > > group item will raise all windows. So

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/897/ --- (Updated 2009-06-27 15:22:07.327479) Review request for Plasma. Changes ---

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Aaron J. Seigo
On Saturday 27 June 2009, Martin Gräßlin wrote: > I like the idea of replacing the menu of the task group. It's kind of > consistent: clicking on a task item will raise the window, clicking on a > group item will raise all windows. Sounds like the right thing to do :-) +1 so we just need a way of

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Martin Gräßlin
Am Samstag 27 Juni 2009 16:44:11 schrieb Marco Martin: > On 6/27/09, Aaron Seigo wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://reviewboard.kde.org/r/897/#review1400 > > -

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Ivan Cukic
> On 2009-06-27 07:31:22, Aaron Seigo wrote: > > i'm with Ivan on this one, i like the idea ... but i'm not comfortable with > > how it's being exposed to the user. there should probably be a way to > > select which effect is associated with the taskbar "show me these windows" > > effect. when

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Martin Gräßlin
> On 2009-06-27 07:31:22, Aaron Seigo wrote: > > i'm with Ivan on this one, i like the idea ... but i'm not comfortable with > > how it's being exposed to the user. there should probably be a way to > > select which effect is associated with the taskbar "show me these windows" > > effect. when

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Marco Martin
On 6/27/09, Aaron Seigo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/897/#review1400 > --- > > > i'm with Ivan on this one,

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Ivan Cukic
> On 2009-06-27 07:31:22, Aaron Seigo wrote: > > i'm with Ivan on this one, i like the idea ... but i'm not comfortable with > > how it's being exposed to the user. there should probably be a way to > > select which effect is associated with the taskbar "show me these windows" > > effect. when

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Ivan Cukic
> On 2009-06-27 04:53:14, Marco Martin wrote: > > i like it! > > i was also experimenting in the taskbar applet, (like with clicking on the > > group while pressing control) and mostly ended up with duplicate code, now, > > i am wondering: > > what about providing a TaskGroupItem::presentWindow

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/897/#review1400 --- i'm with Ivan on this one, i like the idea ... but i'm not comfortable

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Aaron Seigo
> On 2009-06-27 04:53:14, Marco Martin wrote: > > i like it! > > i was also experimenting in the taskbar applet, (like with clicking on the > > group while pressing control) and mostly ended up with duplicate code, now, > > i am wondering: > > what about providing a TaskGroupItem::presentWindow

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Ivan Cukic
> On 2009-06-27 04:53:14, Marco Martin wrote: > > i like it! > > i was also experimenting in the taskbar applet, (like with clicking on the > > group while pressing control) and mostly ended up with duplicate code, now, > > i am wondering: > > what about providing a TaskGroupItem::presentWindow

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Michal Dutkiewicz
> On 2009-06-27 04:53:14, Marco Martin wrote: > > i like it! > > i was also experimenting in the taskbar applet, (like with clicking on the > > group while pressing control) and mostly ended up with duplicate code, now, > > i am wondering: > > what about providing a TaskGroupItem::presentWindow

Re: Review Request: Activate present windows from task group context menu

2009-06-27 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/897/#review1397 --- i like it! i was also experimenting in the taskbar applet, (like with c

Review Request: Activate present windows from task group context menu

2009-06-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/897/ --- Review request for Plasma. Summary --- Patch adds a new menu entry to task g