Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 3:14 p.m., Ivan Čukić wrote: > > experimental/libkactivities/resourceinstance.h, line 52 > > > > > > The thing I don't like about the /empty/ constructor is that the user > > could thing the class

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 3:14 p.m., Ivan Čukić wrote: > > experimental/libkactivities/resourceinstance.h, line 52 > > > > > > The thing I don't like about the /empty/ constructor is that the user > > could thing the class

Re: Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3062 --- experimental/libkactivities/resourceinstance.h

Re: Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/ --- (Updated May 2, 2011, 3:11 p.m.) Review request for Nepomuk and Plasma.

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 1:20 p.m., Aaron J. Seigo wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > sounds like a signal rather than a method. > > > > also, is this about the URI chan

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote: > > experimental/libkactivities/ResourceInstance.h, line 105 > > > > > > As mentioned on IRC I am not sure about this. How would accessing the > > new resource be

Re: Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3052 --- experimental/libkactivities/ResourceInstance.h

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > How about an event enum instead of one method for each event type? > > Something like resou

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 12:55 p.m., Marco Martin wrote: > > experimental/libkactivities/ResourceInstance.h, line 105 > > > > > > what about a property? has it symmetric behaviour with changeUri()? It is by default symmet

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 1:03 p.m., Sebastian Trueg wrote: > > experimental/libkactivities/ResourceInstance.h, line 62 > > > > > > What is the mimetype required for? Some resources might not even have a > > "real" mimetype

Re: Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/ --- (Updated May 2, 2011, 1:07 p.m.) Review request for Nepomuk and Plasma.

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 1:04 p.m., Ivan Čukić wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > register, notify... ? disregard this ^^^ (should have been posted up) - Ivan ---

Re: Review Request: Activity ResourceInstance class for API review

> On May 2, 2011, 12:55 p.m., Marco Martin wrote: > > experimental/libkactivities/ResourceInstance.h, line 77 > > > > > > modified sounds a bit a signal name? maybe registerModification()? register, notify... ? I do

Re: Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3046 --- experimental/libkactivities/ResourceInstance.h

Re: Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3043 --- experimental/libkactivities/ResourceInstance.h

Re: Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/#review3044 --- experimental/libkactivities/ResourceInstance.h

Review Request: Activity ResourceInstance class for API review

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101273/ --- Review request for Nepomuk, Plasma, Aaron J. Seigo, Marco Martin, and Sebast