Review Request: Add an Inhibit button to the Battery applet

2011-10-03 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102757/ --- Review request for Plasma and Sebastian Kügler. Description --- As

Re: Review Request: Add an Inhibit button to the Battery applet

2011-10-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102757/#review7016 --- A few remarks inline. I'm not really happy with it UI wise yet,

Re: Review Request: Add an Inhibit button to the Battery applet

2011-10-03 Thread Dario Freddi
On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote: A few remarks inline. I'm not really happy with it UI wise yet, and I'd like to see a screenshot of it in action. Especially that row of iconitems can already grow quite wide, imagine hibernate and suspend both available, and the

Re: Review Request: Add an Inhibit button to the Battery applet

2011-10-03 Thread Aaron J. Seigo
On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote: A few remarks inline. I'm not really happy with it UI wise yet, and I'd like to see a screenshot of it in action. Especially that row of iconitems can already grow quite wide, imagine hibernate and suspend both available, and the

Re: Review Request: Add an Inhibit button to the Battery applet

2011-10-03 Thread Dario Freddi
On Oct. 3, 2011, 10:18 a.m., Sebastian Kügler wrote: A few remarks inline. I'm not really happy with it UI wise yet, and I'd like to see a screenshot of it in action. Especially that row of iconitems can already grow quite wide, imagine hibernate and suspend both available, and the

Re: Review Request: Add an Inhibit button to the Battery applet

2011-10-03 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102757/ --- (Updated Oct. 3, 2011, 12:28 p.m.) Review request for Plasma and

Re: Review Request: Add an Inhibit button to the Battery applet

2011-10-03 Thread Dario Freddi
On Oct. 3, 2011, 1:19 p.m., Aaron J. Seigo wrote: i like the direction of this towards simplicity, predictability and making good decisions in the software .. thanks :) On Oct. 3, 2011, 1:19 p.m., Aaron J. Seigo wrote: plasma/generic/applets/battery/battery.cpp, line 540