---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review886
---
Ship it!
Aside from a couple of minor nitpicks below I think the patch
On 2009-04-02 13:56:47, Fredrik Höglund wrote:
I think in general the code looks good, but there are still numerous coding
style issues, especially with the way the code is indented.
Shantanu Tushar Jha wrote:
Oh, I apologise for that, but I'm unable to figure out where I've messed
On 2009-04-02 13:56:47, Fredrik Höglund wrote:
I think in general the code looks good, but there are still numerous coding
style issues, especially with the way the code is indented.
Shantanu Tushar Jha wrote:
Oh, I apologise for that, but I'm unable to figure out where I've messed
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
(Updated 2009-04-02 08:55:49.469863)
Review request for Plasma.
Changes
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
(Updated 2009-04-02 13:21:02.238361)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review796
---
I think in general the code looks good, but there are still numerous
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1255
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1255
The implementation of this function suffers from the same problem as
the one above.
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is
On 2009-03-20 14:07:32, Fredrik Höglund wrote:
/trunk/KDE/kdebase/apps/plasma/applets/folderview/iconview.cpp, line 1208
http://reviewboard.kde.org/r/368/diff/2/?file=3392#file3392line1208
A problem with the way this function is implemented is that it assumes
that the view is
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
Review request for Plasma.
Summary
---
This partly addresses the above bug,
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review537
---
this is a very important feature to add, so thanks for working on it.
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
(Updated 2009-03-20 10:21:32.420468)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/#review540
---
logic looks alright, just a couple of code style issues to fix and then
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/368/
---
(Updated 2009-03-20 22:14:51.976726)
Review request for Plasma.
Changes
18 matches
Mail list logo
