On 2010-04-12 06:55:52, Alessandro Diaferia wrote:
/trunk/KDE/kdebase/workspace/plasma/generic/runners/calculator/qalculate_engine.cpp,
line 45
http://reviewboard.kde.org/r/3483/diff/1/?file=22478#file22478line45
I know nothing about libqalculate but doesn't this lead to a mem
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3483/
---
(Updated 2010-04-14 12:47:15.497906)
Review request for Plasma and Aaron Seigo.
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3483/#review5035
---
Ship it!
Now that even whitespaces are over i'd say: go for it!
-
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3483/#review4973
---
I didn't try the patch locally but the code seems good to me and
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3483/
---
(Updated 2010-04-12 09:01:06.760037)
Review request for Plasma and Aaron Seigo.
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3483/
---
Review request for Plasma and Aaron Seigo.
Summary
---
Adds libqalculate
