Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-26 Thread Jacopo De Simoi
> On May 22, 2010, Jacopo De Simoi wrote: > > I'm playing around with that now, and here's what I got so far... > > how do you like it? > > it puts a third size of icon in the dialog, and it isn't really aligned with > anything visually. Yep, I was trying to make it look like an extender in fact

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-26 Thread Jacopo De Simoi
> > Like one more font face > > and not aligned with anything either. > > the font should be the same as the top header, so there shouldn't be another > font face. as for alignment, iirc they are right aligned. You recall correctly, but it has been changed since :) Right aligning with (un)mount

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-25 Thread Aaron J. Seigo
On May 25, 2010, Ignat Semenov wrote: > And maybe no text at all for the separators? then they are completely random. the point is to offer a hint to the user. > Like one more font face > and not aligned with anything either. the font should be the same as the top header, so there shouldn't be a

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-25 Thread Ignat Semenov
And maybe no text at all for the separators? Like one more font face and not aligned with anything either. (Yes, I like to remove stuff ;) On Tue, May 25, 2010 at 8:22 PM, Aaron J. Seigo wrote: > On May 22, 2010, Jacopo De Simoi wrote: >> I'm playing around with that now, and here's what I got so

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-25 Thread Aaron J. Seigo
On May 22, 2010, Jacopo De Simoi wrote: > I'm playing around with that now, and here's what I got so far... > how do you like it? it puts a third size of icon in the dialog, and it isn't really aligned with anything visually. my recommendation would be to just ditch the icon altogether. it doesn

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-22 Thread Jacopo De Simoi
> > you mean, to make the icon smaller? > > Yes, it takes *way* too much space. And, what's the point? The user > will learn very soon what this widget does, so then it's kinda > unnecessary. There are a lot of other plasmoids out there. Some of > them do have a header, some of them don't. I have

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-22 Thread Ignat Semenov
On Sat, May 22, 2010 at 1:44 PM, Jacopo De Simoi wrote: >> Well, as far as device notifier goes, there's a couple more things about it >> that I'd like to see fixed as well. > > Here I am, the device notifier mantainer, at your service :) Nice to meet you :) >> This one about tooltips sounds nic

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-22 Thread Jacopo De Simoi
> Well, as far as device notifier goes, there's a couple more things about it > that I'd like to see fixed as well. Here I am, the device notifier mantainer, at your service :) > This one about tooltips sounds nice, but then it kinda duplicates what's in > the real device list, and there seems

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-21 Thread Aaron Seigo
> On 2010-05-21 15:43:26, Aaron Seigo wrote: > > unfortunately it's too late for 4.5 due to the string freeze, but this > > should go into 4.6. in fact, i'd like to see it change from being the last > > plugged in device to perhaps a list of all devices plugged in along with > > their mount st

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-21 Thread Ignat Semenov
> On 2010-05-21 15:43:26, Aaron Seigo wrote: > > unfortunately it's too late for 4.5 due to the string freeze, but this > > should go into 4.6. in fact, i'd like to see it change from being the last > > plugged in device to perhaps a list of all devices plugged in along with > > their mount st

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-21 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4100/#review5806 --- unfortunately it's too late for 4.5 due to the string freeze, but this

Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-21 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4100/ --- Review request for Plasma. Summary --- Currently, device notifier tooltips