Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-25 Thread Anselmo Lacerda S. de Melo
On Wed, Nov 25, 2009 at 11:10, Petri Damstén wrote: > On Wednesday 25 November 2009 07:30:03 Anselmo Melo wrote: >> --- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/2191/ >> --

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-25 Thread Petri Damstén
On Wednesday 25 November 2009 07:30:03 Anselmo Melo wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2191/ > --- > > (Updated 200

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-24 Thread Anselmo Melo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2191/ --- (Updated 2009-11-25 05:30:03.553432) Review request for Plasma. Changes --

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-23 Thread Artur Souza (MoRpHeUz)
Hey! On Monday 23 November 2009, 15:39 Anselmo Lacerda S. de Melo wrote: > WIP to make the close button work. A question: Should this button > close only the widgets explorer (and show the panel settings again) or > should it close both? Probably just widgets explorer as it may appear without the

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-23 Thread Anselmo Lacerda S. de Melo
On Mon, Nov 23, 2009 at 10:26 AM, Petri Damstén wrote: > Modified the diff so it puts the Get New Widgets to the filter row: > http://kotisivu.lumonetti.fi/damu0/misc/we.diff > > It also adds close button but It's not working yet: > http://kotisivu.lumonetti.fi/damu0/images/add-widgets1.png Great

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-23 Thread Petri Damstén
On Friday 20 November 2009 22:15:45 Anselmo Melo wrote: > > On 2009-11-20 19:46:47, Marco Martin wrote: > > > i still think the button should be between the input field and the > > > tabbar, to not take even more vertical space > > > > Anselmo Melo wrote: > > Nica. I'll change that and update t

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-20 Thread Anselmo Melo
> On 2009-11-20 19:46:47, Marco Martin wrote: > > i still think the button should be between the input field and the tabbar, > > to not take even more vertical space > > Anselmo Melo wrote: > Nica. I'll change that and update the screenshot. Hm... well, the input field and the tabbar are p

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-20 Thread Anselmo Melo
> On 2009-11-20 19:46:47, Marco Martin wrote: > > i still think the button should be between the input field and the tabbar, > > to not take even more vertical space Nica. I'll change that and update the screenshot. - Anselmo --- This

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-20 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2191/#review3208 --- i still think the button should be between the input field and the tab

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-20 Thread Anselmo Melo
> On 2009-11-17 09:01:45, Marco Martin wrote: > > ths is absolutely needed, to not face a dig regression in 4.4... can't > > really try the patch right now, can you provide a screenshot of it? Sorry about the dalay =/The screenshots show the button and the menu added. - Anselmo

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-20 Thread Anselmo Melo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2191/ --- (Updated 2009-11-20 19:41:08.718732) Review request for Plasma. Summary --

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-19 Thread Petri Damstén
On Thursday 19 November 2009 13:28:01 Marco Martin wrote: > > Another issues: > > * I'm missing remove and about buttons. At least about dialog would be > > important for kde-look.org plasmoids. Is the Applet info popup right > > place for those? > > in the tooltip yes. > scripted plasmoids should

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-19 Thread Marco Martin
On Thu, Nov 19, 2009 at 8:20 AM, Chani wrote: >> * Could the icons have two rows of text? >> * Sometimes search box won't accept focus and clicking desktop does not >>  hide widgets explorer (Previous add widgets dialog also had focus on >>  search at start which was good imho). >> >> Petri >> > >

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-19 Thread Marco Martin
On Thu, Nov 19, 2009 at 7:18 AM, Petri Damstén wrote: > On Tuesday 17 November 2009 11:01:40 Marco Martin wrote: >> --- >> This is an automatically generated e-mail. To reply, visit: >> http://reviewboard.kde.org/r/2191/#review3141 >> ---

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-18 Thread Chani
> > Another issues: > * I'm missing remove and about buttons. At least about dialog would be > important for kde-look.org plasmoids. Is the Applet info popup right place > for those? where that uninstall button is? yeah, iirc that was where they were going to go > * Could the icons have two ro

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-18 Thread Petri Damstén
On Tuesday 17 November 2009 11:01:40 Marco Martin wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/2191/#review3141 > --- > > >

Re: Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-17 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2191/#review3141 --- ths is absolutely needed, to not face a dig regression in 4.4... can't

Review Request: Draft: Widgets Explorer "Add Widgets"

2009-11-16 Thread Anselmo Melo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2191/ --- Review request for Plasma. Summary --- "Add widgets" button in the new widg