Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-13 Thread Marco Martin
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/#review8098 --- Ship it! - Marco On 2010-10-12 02:17:13, Anthony Bryant wrote:

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Anthony Bryant
> On 2010-10-12 08:21:53, Marco Martin wrote: > > I think those changes are good, i'm just not sure about the removal of the > > shuffle button. > > there should be at least a context button action with it, because should be > > possible to reshuffle it in any moment (i.e. want to start a new g

Re: Review Request: Fifteen puzzle config dialog upgrade

2010-10-12 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/#review8084 --- I think those changes are good, i'm just not sure about the remova

Review Request: Fifteen puzzle config dialog upgrade

2010-10-11 Thread Anthony Bryant
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5608/ --- Review request for Plasma. Summary --- This patch fixes some usability