Re: Review Request: Fix battery applet screen power management

2012-11-02 Thread Oliver Henshaw
On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote: This review has been submitted with commit e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch push/4.9. Christoph Feck wrote: push/4.9 is not a valid branch name for kde-workspace. If these commits should be part

Re: Review Request: Fix battery applet screen power management

2012-11-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review21321 --- This review has been submitted with commit

Re: Review Request: Fix battery applet screen power management

2012-11-01 Thread Christoph Feck
On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote: This review has been submitted with commit e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch push/4.9. push/4.9 is not a valid branch name for kde-workspace. If these commits should be part of KDE 4.9.3 release, you

Re: Review Request: Fix battery applet screen power management

2012-11-01 Thread Ben Cooksley
On Nov. 1, 2012, 3:18 p.m., Commit Hook wrote: This review has been submitted with commit e1bf8805b3d0c8ddf22805f334faec8bd678742e by Oliver Henshaw to branch push/4.9. Christoph Feck wrote: push/4.9 is not a valid branch name for kde-workspace. If these commits should be part

Re: Review Request: Fix battery applet screen power management

2012-10-15 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review20366 --- Ship it! Ship It! - Lukáš Tinkl On Oct. 10, 2012, 3:13

Review Request: Fix battery applet screen power management

2012-10-10 Thread Oliver Henshaw
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/ --- Review request for Plasma and Solid. Description --- Fix battery

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106784/#review20147 --- Good catch, is this code only in master or also in 4.9 branch?

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Sebastian Kügler
On Wednesday, October 10, 2012 15:43:11 Lukáš Tinkl wrote: Good catch, is this code only in master or also in 4.9 branch? Should be the same in both, this fix needs to go into both branches. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9

Re: Review Request: Fix battery applet screen power management

2012-10-10 Thread Oliver Henshaw
On Oct. 10, 2012, 3:43 p.m., Lukáš Tinkl wrote: Good catch, is this code only in master or also in 4.9 branch? Yep, it's needed in 4.9 branch and master. - Oliver --- This is an automatically generated e-mail. To reply, visit: