Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/#review19212 --- This review has been submitted with commit

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-20 Thread Ralf Jung
Hi, Ralf Jung wrote: Actually, the patch presented here does not break BC. This function I renamed is part of CalendarPrivate and therefore can not be used from the outside. The BC breakage would (possibly) be introduced by removing Calendar::resizeEvent, which is why I just stubbed it out

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-20 Thread Sebastian Kügler
On Thursday, September 20, 2012 11:40:41 Ralf Jung wrote: Hi, Ralf Jung wrote: Actually, the patch presented here does not break BC. This function I renamed is part of CalendarPrivate and therefore can not be used from the outside. The BC breakage would (possibly) be introduced by

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-20 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/#review19223 --- This review has been submitted with commit

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-19 Thread Ralf Jung
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: Patch looks good now, thanks a lot! Please commit it to KDE/4.9 and master. Sebastian Kügler wrote: Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question? Is it

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-19 Thread Sebastian Kügler
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: Patch looks good now, thanks a lot! Please commit it to KDE/4.9 and master. Sebastian Kügler wrote: Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question? Is it

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/ --- (Updated Sept. 18, 2012, 5:40 p.m.) Review request for Plasma. Changes

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/#review19132 --- Ship it! Patch looks good now, thanks a lot! Please commit

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Sebastian Kügler
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: Patch looks good now, thanks a lot! Please commit it to KDE/4.9 and master. Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question? Is it okay to remove a no longer needed overload of a

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-18 Thread Marco Martin
On Sept. 18, 2012, 10:13 p.m., Sebastian Kügler wrote: Patch looks good now, thanks a lot! Please commit it to KDE/4.9 and master. Sebastian Kügler wrote: Ah, crap. I missed your question about the possible BIC issue. Can someone answer this question? Is it

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-16 Thread Ralf Jung
On Sept. 14, 2012, 3 p.m., Sebastian Kügler wrote: The user can change the size of the calendar in two ways: - when the applet is in a panel / popup by dragging the edges - when it's on the desktop, using the applet handle Applying the config changing it to a different size is

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-16 Thread Ralf Jung
On Sept. 14, 2012, 3 p.m., Sebastian Kügler wrote: The user can change the size of the calendar in two ways: - when the applet is in a panel / popup by dragging the edges - when it's on the desktop, using the applet handle Applying the config changing it to a different size is

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-16 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/ --- (Updated Sept. 15, 2012, 7:32 p.m.) Review request for Plasma. Changes

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-15 Thread Sebastian Kügler
On Sept. 14, 2012, 3 p.m., Sebastian Kügler wrote: The user can change the size of the calendar in two ways: - when the applet is in a panel / popup by dragging the edges - when it's on the desktop, using the applet handle Applying the config changing it to a different size is

Re: Review Request: Fix setting the size of the calendar of clocks

2012-09-14 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/#review18976 --- The user can change the size of the calendar in two ways: -

Review Request: Fix setting the size of the calendar of clocks

2012-09-13 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106441/ --- Review request for Plasma. Description --- Currently, the size of