Re: Review Request: Fix the minimum size of some applets

> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote: > > applets/pastebin/pastebin.cpp, line 263 > > > > > > why 33? > > Maarten De Meyer wrote: > As I explained to David: > "If it is 32 the iconSize() met

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/ --- (Updated June 29, 2012, 11:13 a.m.) Review request for Plasma. Changes -

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review15224 --- patch seems broken, perhaps was not made against current master

Re: Review Request: Fix the minimum size of some applets

> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote: > > applets/pastebin/pastebin.cpp, line 263 > > > > > > why 33? As I explained to David: "If it is 32 the iconSize() method (as I understand it) selects a small

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/ --- (Updated June 22, 2012, 6:17 a.m.) Review request for Plasma. Changes --

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14977 --- applets/showdashboard/showdashboard.cpp

Re: Review Request: Fix the minimum size of some applets

> On June 14, 2012, 10:33 a.m., Aaron J. Seigo wrote: > > applets/timer/timer.cpp, line 49 > > > > > > this will break it in smaller panels. Also the indentation is not correct. > On June 14, 2012, 10:33 a.m., Aar

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14975 --- Is there any update on this review? - Mark Gaiser On June 13

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14728 --- applets MUST be scalable down to smaller sizes, otherwise they

Re: Review Request: Fix the minimum size of some applets

> On June 13, 2012, 5:49 p.m., David Edmundson wrote: > > applets/pastebin/pastebin.cpp, line 263 > > > > > > Where did you get the number 33 from? If it is 32 the iconSize() method selects a smaller icon. iconSize

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/ --- (Updated June 13, 2012, 7:19 p.m.) Review request for Plasma. Changes --

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/ --- (Updated June 13, 2012, 3:42 p.m.) Review request for Plasma. Changes --

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14700 --- When you made this new patch, according to reviewboard you "del

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/ --- (Updated June 13, 2012, 2:22 p.m.) Review request for Plasma. Changes --

Re: Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/#review14677 --- applets/showdashboard/showdashboard.cpp

Review Request: Fix the minimum size of some applets

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105234/ --- Review request for Plasma. Description --- This fixes the minimum siz