Review Request: Fixes a crash in Qalculate applet (bug 241006)

2010-06-09 Thread Matteo Agostinelli
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4265/ --- Review request for Plasma. Summary --- This patch fixes a crash when browsi

Re: Review Request: Fixes a crash in Qalculate applet (bug 241006)

2010-06-09 Thread Matteo Agostinelli
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4265/ --- (Updated 2010-06-09 14:22:07.861902) Review request for Plasma. Changes --

Re: Review Request: Fixes a crash in Qalculate applet (bug 241006)

2010-06-09 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4265/#review6055 --- Ship it! looks good, and one more bug down for 4.5 :) /trunk/KDE/kd

Re: Review Request: Fixes a crash in Qalculate applet (bug 241006)

2010-06-10 Thread Matteo Agostinelli
> On 2010-06-09 16:00:53, Aaron Seigo wrote: > > /trunk/KDE/kdeplasma-addons/applets/qalculate/qalculate_history.cpp, lines > > 41-60 > > > > > > these changes aren't part of the fix, correct? just clean ups? Yes, exactl