Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-20 Thread Omer F. USTA
On 2009-07-19 00:16:17, Omer F. USTA wrote: Hi , just to learn why or instead of common || ? in if (m_bottom_right == 1 or m_bottom_left == 1) { Sujith H wrote: I changed it to '||'. This looks committed with r999070 and r999083 it will be nice to mark as submitted - Omer F.

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-20 Thread Aaron J. Seigo
On Sunday 19 July 2009, Michael Jansen wrote: On Sunday 19 July 2009 02:55:06 Sebastian Kügler wrote: On Sunday 19 July 2009 02:16:13 Omer F. USTA wrote: Hi , just to learn why or instead of common || ? in if (m_bottom_right == 1 or m_bottom_left == 1) { I personally find or more

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-19 Thread Sujith H
On 2009-07-18 18:23:09, Anne-Marie Mahfouf wrote: I tested and indeed it works fine and it fixes the corner problem. It's a ship it and backport it from me. Thanks for testing it :) - Sujith --- This is an automatically generated

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-19 Thread Sujith H
On 2009-07-19 00:16:17, Omer F. USTA wrote: Hi , just to learn why or instead of common || ? in if (m_bottom_right == 1 or m_bottom_left == 1) { I changed it to '||'. - Sujith --- This is an automatically generated e-mail. To

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-19 Thread Michael Jansen
On Sunday 19 July 2009 02:55:06 Sebastian Kügler wrote: On Sunday 19 July 2009 02:16:13 Omer F. USTA wrote: Hi , just to learn why or instead of common || ? in if (m_bottom_right == 1 or m_bottom_left == 1) { I personally find or more readable, though I think || is more common in KDE

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-18 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/#review1653 --- I tested and indeed it works fine and it fixes the corner problem.

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-18 Thread Sebastian Kügler
On Sunday 19 July 2009 02:16:13 Omer F. USTA wrote: Hi , just to learn why or instead of common || ? in if (m_bottom_right == 1 or m_bottom_left == 1) { I personally find or more readable, though I think || is more common in KDE code. Maybe there are some compiler intricacies to it.

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-18 Thread Omer F. USTA
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/#review1655 --- Hi , just to learn why or instead of common || ? in if

Review Request: Fixing Bball getting stuck at the corner

2009-07-17 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/ --- Review request for Plasma, Aaron Seigo and Sebastian Kügler. Summary ---

Re: Review Request: Fixing Bball getting stuck at the corner

2009-07-17 Thread Sujith H
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/ --- (Updated 2009-07-17 23:37:46.001490) Review request for Plasma, Aaron Seigo,