Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-08-09 Thread Alex Merry
On July 15, 2011, 3:28 p.m., Martin Gräßlin wrote: The code from the SoK project is now in an own branch: https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/2780fd91810bad353ac33422ce4b3eab291c4b47 Comparing the two I prefer the SoK commit as it doesn't

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-17 Thread Alex Merry
On July 15, 2011, 3:28 p.m., Martin Gräßlin wrote: The code from the SoK project is now in an own branch: https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/2780fd91810bad353ac33422ce4b3eab291c4b47 Comparing the two I prefer the SoK commit as it doesn't

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-17 Thread Martin Gräßlin
On July 15, 2011, 3:28 p.m., Martin Gräßlin wrote: The code from the SoK project is now in an own branch: https://projects.kde.org/projects/kde/kdebase/kde-workspace/repository/revisions/2780fd91810bad353ac33422ce4b3eab291c4b47 Comparing the two I prefer the SoK commit as it doesn't

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/#review4741 --- The code from the SoK project is now in an own branch:

Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/ --- Review request for kwin, Plasma, Aaron J. Seigo, and Martin Gräßlin.

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/#review4680 --- I disabled it for Plasma active, but that may not be

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Alex Merry
On July 13, 2011, 12:54 p.m., Aaron J. Seigo wrote: I disabled it for Plasma active, but that may not be appropriate. we still need screen locking in Active, so this probably isn't entirely correct. what we probably want, however, is a replacement for the actual lock process which

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/#review4689 --- before I do a proper review I have a few questions: 1. How

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/ --- (Updated July 13, 2011, 3:54 p.m.) Review request for kwin, Plasma, Aaron

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Alex Merry
On July 13, 2011, 3:38 p.m., Martin Gräßlin wrote: before I do a proper review I have a few questions: 1. How does this align with the work our Season of KDE student, Farhad, is doing? To my knowledge he already did what this review request provides. Could you please add him to CC

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101943/ --- (Updated July 13, 2011, 4:07 p.m.) Review request for kwin, Plasma, Aaron

Re: Review Request: Move screensaver and locking functionality to kwin from krunner

2011-07-13 Thread Martin Gräßlin
On July 13, 2011, 3:38 p.m., Martin Gräßlin wrote: before I do a proper review I have a few questions: 1. How does this align with the work our Season of KDE student, Farhad, is doing? To my knowledge he already did what this review request provides. Could you please add him to CC