Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-12-04 Thread Anne-Marie Mahfouf
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9126 --- The bug is in the Notes code. It you remove lines 412 - 417 from

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-30 Thread Stephen Kelly
On 2010-11-30 01:04:03, Davide Bettio wrote: Should we apply this patch while waiting someone who fix this bug in Qt? Aaron Seigo wrote: sure (if only because the bug has been closed as out of scope), but annotate the code with a comment explaining the situation and a link to the

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-30 Thread Anne-Marie Mahfouf
On 2010-11-30 01:04:03, Davide Bettio wrote: Should we apply this patch while waiting someone who fix this bug in Qt? Aaron Seigo wrote: sure (if only because the bug has been closed as out of scope), but annotate the code with a comment explaining the situation and a link to the

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-30 Thread Stephen Kelly
On 2010-11-30 01:04:03, Davide Bettio wrote: Should we apply this patch while waiting someone who fix this bug in Qt? Aaron Seigo wrote: sure (if only because the bug has been closed as out of scope), but annotate the code with a comment explaining the situation and a link to the

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-29 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9041 --- More likely a Qt Bug. Seems similar to this one which I filed a

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-29 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/#review9050 --- Should we apply this patch while waiting someone who fix this bug

Re: Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-29 Thread Aaron Seigo
On 2010-11-30 01:04:03, Davide Bettio wrote: Should we apply this patch while waiting someone who fix this bug in Qt? sure (if only because the bug has been closed as out of scope), but annotate the code with a comment explaining the situation and a link to the bug report on the qt bug

Review Request: Notes widget: Working bold/italic/underline/strike out even when the note text is empty

2010-11-28 Thread Davide Bettio
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6005/ --- Review request for Plasma and Stephen Kelly. Summary --- Text format