> On March 4, 2011, 4:02 p.m., Aaron J. Seigo wrote:
> > nice idea :)
> >
> > there is a string translation (localization) issue on lines 615-617 and a
> > handful of whitespace issues. once those are addressed, please commit.
>
> J Janz wrote:
> * On strings, some thoughts:
>
>
> On March 4, 2011, 4:02 p.m., Aaron J. Seigo wrote:
> > nice idea :)
> >
> > there is a string translation (localization) issue on lines 615-617 and a
> > handful of whitespace issues. once those are addressed, please commit.
>
> J Janz wrote:
> * On strings, some thoughts:
>
>
> On March 4, 2011, 4:02 p.m., Aaron J. Seigo wrote:
> > nice idea :)
> >
> > there is a string translation (localization) issue on lines 615-617 and a
> > handful of whitespace issues. once those are addressed, please commit.
>
> J Janz wrote:
> * On strings, some thoughts:
>
>
> On March 4, 2011, 4:02 p.m., Aaron J. Seigo wrote:
> > nice idea :)
> >
> > there is a string translation (localization) issue on lines 615-617 and a
> > handful of whitespace issues. once those are addressed, please commit.
* On strings, some thoughts:
- For the options, "No title" or,
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/#review1761
---
Ship it!
nice idea :)
there is a string translation (localizat
> On Feb. 28, 2011, 3:45 p.m., Sebastian Kügler wrote:
> > There's no need to add a UI option for this, the user should just be able
> > to set an empty title and the header would then get hidden / collapsed.
> >
> > Right now, this doesn't happen since when the label is empty, the default
> >
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/
---
(Updated March 3, 2011, 1:39 p.m.)
Review request for Plasma.
Changes
--
On Tuesday, March 1, 2011, Farhad Hedayati Fard wrote:
> > On Feb. 28, 2011, 3:45 p.m., Sebastian Kügler wrote:
> > > There's no need to add a UI option for this, the user should just be
> > > able to set an empty title and the header would then get hidden /
> > > collapsed.
> > >
> > > Right now,
> On Feb. 28, 2011, 3:45 p.m., Sebastian Kügler wrote:
> > There's no need to add a UI option for this, the user should just be able
> > to set an empty title and the header would then get hidden / collapsed.
> >
> > Right now, this doesn't happen since when the label is empty, the default
> >
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/#review1698
---
There's no need to add a UI option for this, the user should jus
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100750/
---
(Updated Feb. 26, 2011, 5:13 p.m.)
Review request for Plasma.
Changes
--
11 matches
Mail list logo