Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-17 Thread Shawn Starr
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/#review2391 --- Ship it! This looks good now. Please commit - Shawn On 2009-09-14

Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-14 Thread Amos Kariuki
> On 2009-09-13 22:28:30, Shawn Starr wrote: > > It looks fine, but please make sure any new strings are wrapped in proper > > i18n(). I cannot approve this commit until that's please. spstarr: I think the only think that needed to be internationalized was the weather summary so correct me if

Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-14 Thread Amos Kariuki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/ --- (Updated 2009-09-14 23:24:56.419041) Review request for Plasma and Shawn Starr.

Re: Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-13 Thread Shawn Starr
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/#review2338 --- It looks fine, but please make sure any new strings are wrapped in pro

Review Request: Patch to add a 7-day (up-to) forecast to the NOAA weather Ion

2009-09-13 Thread Amos Kariuki
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1584/ --- Review request for Plasma and Shawn Starr. Summary --- The patch uses the R