On 2009-03-24 06:24:42, Kevin Ottens wrote:
trunk/KDE/kdelibs/plasma/abstractrunner.h, line 83
http://reviewboard.kde.org/r/372/diff/2/?file=3421#file3421line83
Why not a default ctor instead? You've accessors anyway and it's mainly
a data store class.
wrote:
a Syntax
On Wednesday 25 March 2009 08:45:08 Kevin Ottens wrote:
Oh, and really no idea why, but it'd feel more natural to me to have the
description coming first in the ctor. Can't find the reason, but felt like
pointing it out anyway.
i18nc(this is why, here's what);
uses this pattern as well, maybe
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/372/#review585
---
trunk/KDE/kdelibs/plasma/abstractrunner.h
On 2009-03-24 06:24:42, Kevin Ottens wrote:
trunk/KDE/kdelibs/plasma/abstractrunner.h, line 83
http://reviewboard.kde.org/r/372/diff/2/?file=3421#file3421line83
Why not a default ctor instead? You've accessors anyway and it's mainly
a data store class.
a Syntax without an
On Tuesday 24 March 2009 20:03:25 Aaron Seigo wrote:
so i'd like to keep addSyntax as that keeps the runners simpler, but add a
setSyntaxes and removing clearSyntaxes does make sense ... thoughts?
I'm fine with keeping addSyntax and adding setSyntaxes (I proposed something
similar before
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/372/
---
Review request for Plasma.
Summary
---
Allows runners to register their
