Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-29 20:56:15, Manuel Mommertz wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 85 > > > > > > should end with: > > -(.*)\\1"); > > this is save as setMinimal is true; > > Ingomar Wesp wrote: >

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-29 20:56:15, Manuel Mommertz wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 85 > > > > > > should end with: > > -(.*)\\1"); > > this is save as setMinimal is true; Actually, I think it's a bit

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8438 --- Ship it! Somehow my comment on the last was lost... so again: Fi

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8437 --- /trunk/KDE/kdelibs/plasma/svg.cpp

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-28 23:30:24.052034) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-28 15:53:45, Marco Martin wrote: > > I'm still not sure wether this will be fast enough, but let's try it Great! Thanks for reviewing. Manuel sent me a few very good suggestions via PM and I noticed a low hanging performance fruit in SharedSvgRenderer::load, so I'm afraid there wi

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8411 --- Ship it! I'm still not sure wether this will be fast enough, but

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-27 22:05:50.543676) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-27 13:23:04.568859) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 23:54:14.696262) Review request for Plasma. Changes --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-25 20:43:20, Marco Martin wrote: > > /trunk/KDE/kdelibs/plasma/svg.cpp, line 259 > > > > > > this creates a renderer too often. > > since the purpose of the cache is avoid to create renderers this is

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8349 --- /trunk/KDE/kdelibs/plasma/svg.cpp

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8346 --- Ship it! Ok, the performance should be acceptable and the patch l

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 15:29:32.167235) Review request for Plasma. Summary --

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

> On 2010-10-25 08:03:51, Manuel Mommertz wrote: > > If you want to use the DOM to find the size hints, you can take a look at > > KGameSvgDocument. It implements a way to find elements by id. This could > > should be usable for you. > > > > And can you please measure how long it takes to load

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/#review8338 --- If you want to use the DOM to find the size hints, you can take a

Re: Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- (Updated 2010-10-25 00:17:45.081898) Review request for Plasma. Summary --

Review Request: Plasma::Svg: Do not require exact match for size hinted elements.

--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5689/ --- Review request for Plasma. Summary --- Previously, if an SVG contained