Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-15 Thread Adenilson Cavalcanti
On 2009-10-14 12:31:38, Adenilson Cavalcanti wrote: /trunk/KDE/kdelibs/plasma/animations/animation.h, line 83 http://reviewboard.kde.org/r/1512/diff/1/?file=10972#file10972line83 It should return a QAbstractAnimation so it covers the case that the animation is complex and it

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-15 Thread Adenilson Cavalcanti
On 2009-10-14 12:31:38, Adenilson Cavalcanti wrote: /trunk/KDE/kdelibs/plasma/animations/animation.h, line 83 http://reviewboard.kde.org/r/1512/diff/1/?file=10972#file10972line83 It should return a QAbstractAnimation so it covers the case that the animation is complex and it

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-13 Thread Adenilson Cavalcanti
On 2009-10-13 09:31:47, Marco Martin wrote: /trunk/KDE/kdelibs/plasma/animations/fade.cpp, line 45 http://reviewboard.kde.org/r/1512/diff/1/?file=10979#file10979line45 this unfortunately will be very slow on x11, but i don't see other ways to do that? No idea if there is another

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-13 Thread Adenilson Cavalcanti
On 2009-09-21 16:26:17, Aaron Seigo wrote: any updates on this? Richard's comments don't seem to be addressed yet. Adenilson Cavalcanti wrote: Aaron is it possible to add my user in the list so I can upload an updated patch? Current updated patch (addresses most of issues commented

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-10-13 Thread makmanalp
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1512/ --- (Updated 2009-10-13 15:06:04.819830) Review request for Plasma, Aaron Seigo,

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-09-21 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1512/#review2413 --- any updates on this? Richard's comments don't seem to be addressed

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-09-04 Thread Richard Moore
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1512/#review2233 --- /trunk/KDE/kdelibs/plasma/animations/abstractanimation.h

Re: Review Request: Plasma + Qt Kinetic GSoC Project - Attempt 2

2009-09-04 Thread Richard Moore
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1512/#review2234 --- /trunk/KDE/kdelibs/plasma/animations/animation.h