Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-29 Thread Antonis Tsiapaliokas
On Aug. 27, 2012, 4:32 p.m., Sebastian Kügler wrote: mainwindow.cpp, line 1026 http://git.reviewboard.kde.org/r/106118/diff/3/?file=81728#file81728line1026 Why not just } else { ? Sorry for my late reply but i am/will be very busy for the following days. Because we always want to

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-27 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- (Updated Aug. 27, 2012, 7:18 a.m.) Review request for kwin, Plasma,

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review18087 --- konsole/konsolepreviewer.cpp

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-27 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- (Updated Aug. 27, 2012, 4:06 p.m.) Review request for kwin, Plasma,

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review18117 --- Ship it! Looking good now :) mainwindow.cpp

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-24 Thread Antonis Tsiapaliokas
On Aug. 23, 2012, 10:19 p.m., Sebastian Kügler wrote: mainwindow.cpp, line 261 http://git.reviewboard.kde.org/r/106118/diff/1/?file=79947#file79947line261 I don't really like this deviation in behavior, mainly because I don't see a reason for it. I think the

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-24 Thread Sebastian Kügler
On Friday, August 24, 2012 10:23:07 Antonis Tsiapaliokas wrote: On Aug. 23, 2012, 10:19 p.m., Sebastian Kügler wrote: mainwindow.cpp, line 261 http://git.reviewboard.kde.org/r/106118/diff/1/?file=79947#file79947lin e261 I don't really like this deviation in behavior, mainly

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review17927 --- konsole/konsolepreviewer.cpp

Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/ --- Review request for kwin, Plasma, Sebastian Kügler, Martin Gräßlin, and

Re: Review Request: Plasmate: Add KWin Scripting support to konsolepreviewer.

2012-08-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106118/#review17847 --- mainwindow.cpp