Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-06-09 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14525 --- Ship it! I still think that the template is quite bad and a

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-06-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated June 6, 2012, 1:27 p.m.) Review request for kwin, Plasma and

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-06-01 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14324 --- the template is still wrong, apart from that I would say it

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-30 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 30, 2012, 3:43 p.m.) Review request for kwin, Plasma and

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-25 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 25, 2012, 2:27 p.m.) Review request for kwin, Plasma and

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/#review14107 --- startpage.cpp

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 24, 2012, 1:17 p.m.) Review request for kwin, Plasma and

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Martin Gräßlin
On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: Antonis Tsiapaliokas wrote: There is still a big issue here. The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Antonis Tsiapaliokas
On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: Antonis Tsiapaliokas wrote: There is still a big issue here. The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-24 Thread Martin Gräßlin
On May 24, 2012, 6:46 a.m., Martin Gräßlin wrote: Antonis Tsiapaliokas wrote: There is still a big issue here. The template of the tabbox that i have put is located in the kde-workspace/kwin/kcmkwin/kwintabbox/qml/main.qml. The main.qml cannot be installed becuase it

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-23 Thread Sebastian Kügler
On Wednesday, May 23, 2012 05:20:25 Antonis Tsiapaliokas wrote: 2)Some lines doesn't have any differences because i have remove some whitespaces and tabs... In the future, please put them in a separate patch, that makes reviewing a lot easier. 1)The icons for the tabbox are wrong. I have

Re: Review Request: Plasmate: Add Tabbox support to the startpage

2012-05-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105011/ --- (Updated May 23, 2012, 5:20 a.m.) Review request for kwin, Plasma and