Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14740 --- Ship it! Ship It! - Aaron J. Seigo On June 14, 2012, 6:31 p

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 14, 2012, 6:31 p.m.) Review request for Plasma. Changes --

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14726 --- getting closer :) publisher/publisher.cpp

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 12, 2012, 12:10 p.m.) Review request for Plasma. Changes -

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14536 --- publisher/remoteinstaller/remoteinstaller.cpp

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

> On June 2, 2012, 3:14 p.m., David Edmundson wrote: > > publisher/remoteinstaller/remoteinstallerdialog.cpp, line 53 > > > > > > This looks like it leaks. > > > > QScopedPointer perhaps? > > Giorgos Tsiapa

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14440 --- Looks good to me. Will let someone from Plasma (sebas probably)

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 4, 2012, 4:54 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14399 --- publisher/remoteinstaller/remoteinstaller.cpp

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

> On June 2, 2012, 3:14 p.m., David Edmundson wrote: > > publisher/remoteinstaller/remoteinstallerdialog.cpp, line 53 > > > > > > This looks like it leaks. > > > > QScopedPointer perhaps? > > Giorgos Tsiapa

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 3, 2012, 9:32 a.m.) Review request for Plasma. Changes ---

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

> On June 2, 2012, 3:14 p.m., David Edmundson wrote: > > publisher/remoteinstaller/remoteinstallerdialog.cpp, line 80 > > > > > > Why is this needed? When you create m_installer, you pass this as the > > parent. >

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

> On June 1, 2012, 6:40 p.m., Aaron J. Seigo wrote: > > publisher/remoteinstaller/remoteinstaller.cpp, line 88 > > > > > > this is the command that fails when there is no display env var set? > > > > if so .

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

> On June 2, 2012, 3:14 p.m., David Edmundson wrote: > > publisher/remoteinstaller/remoteinstaller.cpp, line 54 > > > > > > Is this display hack needed with the newly patched plasmapkg? since there is no need for th

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14379 --- Looks good to me (though I'm not too involved in plasma, so I w

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14344 --- publisher/remoteinstaller/remoteinstaller.cpp

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated June 1, 2012, 6:11 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14273 --- publisher/remoteinstaller/remoteinstaller.cpp

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14272 --- publisher/remoteinstaller/remoteinstaller.cpp

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14268 --- - Giorgos Tsiapaliwkas On May 29, 2012, 3:42 p.m., Giorgos Ts

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

> On May 27, 2012, 6:41 p.m., Aaron J. Seigo wrote: > > publisher/remoteinstaller/remoteinstaller.h, lines 18-26 > > > > > > this class has one static method. just merge it into the remote > > installer ui. I haven

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- (Updated May 29, 2012, 3:42 p.m.) Review request for Plasma. Changes ---

Re: Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/#review14210 --- i'm unsure if the user should have to enter the tmp directory o

Review Request: Plasmate: request to merge terietor/remoteinstaller to master

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105032/ --- Review request for Plasma. Description --- Hello, in terietor/remote