Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-30 Thread Aaron J. Seigo
On Sept. 26, 2011, 12:23 p.m., Aaron J. Seigo wrote: mainwindow.cpp, lines 134-143 http://git.reviewboard.kde.org/r/101916/diff/2/?file=37045#file37045line134 unecessary change. Giorgos Tsiapaliwkas wrote: Aaron in your previous reply you said that the =0 codes are not

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-30 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/#review6951 --- Ship it! Ship It! - Aaron J. Seigo On Sept. 23, 2011, 4:20

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-27 Thread Giorgos Tsiapaliwkas
On Sept. 26, 2011, 12:23 p.m., Aaron J. Seigo wrote: mainwindow.cpp, lines 134-143 http://git.reviewboard.kde.org/r/101916/diff/2/?file=37045#file37045line134 unecessary change. Aaron in your previous reply you said that the =0 codes are not needed. What changed?:) - Giorgos

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-26 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/#review6828 --- mainwindow.cpp

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-09-23 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/ --- (Updated Sept. 23, 2011, 4:20 p.m.) Review request for Plasma. Changes

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-08-23 Thread Sebastian Kügler
On Monday, July 11, 2011 20:12:20 Giorgos Tsiapaliwkas wrote: http://git.reviewboard.kde.org/r/101916/ I was looking at the projectmanager.projectmanager.[h/cpp] and i noticed that there wasn't no destructor. The patch adds a destructor at projectmanager and changed a bit the mainwindow.cpp.

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-07-24 Thread Aaron J. Seigo
On July 11, 2011, 6:27 p.m., Giorgos Tsiapaliwkas wrote: projectmanager/projectmanager.cpp, lines 73-79 http://git.reviewboard.kde.org/r/101916/diff/1/?file=26726#file26726line73 Why in general the destructors of plasmate doesn't do something like that?? Aaron J. Seigo wrote:

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-07-23 Thread Giorgos Tsiapaliwkas
On July 11, 2011, 6:27 p.m., Giorgos Tsiapaliwkas wrote: projectmanager/projectmanager.cpp, lines 73-79 http://git.reviewboard.kde.org/r/101916/diff/1/?file=26726#file26726line73 Why in general the destructors of plasmate doesn't do something like that?? Aaron J. Seigo wrote:

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-07-12 Thread Aaron J. Seigo
On July 11, 2011, 6:27 p.m., Giorgos Tsiapaliwkas wrote: projectmanager/projectmanager.cpp, lines 73-79 http://git.reviewboard.kde.org/r/101916/diff/1/?file=26726#file26726line73 Why in general the destructors of plasmate doesn't do something like that?? the more typical

Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-07-11 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/ --- Review request for Plasma. Summary --- hello, I was looking at the

Re: Review Request: Plasmate:add a destructor and some changes to the destructor of mainwindow.ccp

2011-07-11 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101916/#review4605 --- mainwindow.cpp