Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-09-24 Thread Beat Wolf
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4119/#review7748 --- can somebody resume what the results of the discussion where? - B

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Ignat Semenov
On 5/25/10, Aaron Seigo wrote: > > "so it's not crammed to the left side as before" > > which is how all the other dialogs are. please don't change one dialog to > some random new style without first discussing it with us on > plasma-de...@kde.org. thanks. if we change this one, then they all need

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Aaron Seigo
> On 2010-05-25 17:28:45, Aaron Seigo wrote: > > what is this patch fixing in the current pager? > > > > the checkbox is precisely how we do them in plasma, and the reasons for > > this is a combination of visual scanability and aesthetics. also, since > > we're in string freeze, we can't chan

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Ignat Semenov
> On 2010-05-25 17:28:45, Aaron Seigo wrote: > > what is this patch fixing in the current pager? > > > > the checkbox is precisely how we do them in plasma, and the reasons for > > this is a combination of visual scanability and aesthetics. also, since > > we're in string freeze, we can't chan

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4119/#review5858 --- what is this patch fixing in the current pager? the checkbox is preci

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-23 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4119/ --- (Updated 2010-05-23 22:52:04.976831) Review request for Plasma. Summary --

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-23 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4119/ --- (Updated 2010-05-23 18:32:54.867447) Review request for Plasma. Changes --

Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-23 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4119/ --- Review request for Plasma. Summary --- This is the final version of the Pag