Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-18 Thread Chani
On April 17, 2009 01:55:27 Aurélien Gâteau wrote: > > On 2009-04-14 15:13:59, Aaron Seigo wrote: > > Shipped, do you think it should be backported? have you tested this with popups *on* the screensaver? (eg. clock plasmoid on screensaver has a calendar popup) it probably won't cause trouble, but

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-17 Thread Beat Wolf
> On 2009-04-14 15:13:59, Aaron Seigo wrote: > > > > Aurélien Gâteau wrote: > Shipped, do you think it should be backported? imho yes, for example kubuntu has a local patch for this and other distris probably too. - Beat --- This

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-17 Thread Aurélien Gâteau
> On 2009-04-14 15:13:59, Aaron Seigo wrote: > > Shipped, do you think it should be backported? - Aurélien --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/#review921 -

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-14 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/#review921 --- Ship it! - Aaron On 2009-04-14 13:17:59, Aurélien Gâteau wrote: > >

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-14 Thread J. Janz
> On 2009-04-14 08:58:10, Aaron Seigo wrote: > > unfortunately, this breaks "passive" mode: if you click on a notification > > and then click off it, it goes away. ok, minor annoyance, right? open the > > clock ... the calendar pops up and then goes away as soon as you click back > > onto the

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/ --- (Updated 2009-04-14 13:17:59.288730) Review request for Plasma. Changes ---

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-14 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/#review916 --- unfortunately, this breaks "passive" mode: if you click on a notificatio

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-14 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/ --- (Updated 2009-04-14 07:48:09.451730) Review request for Plasma. Changes ---

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-11 Thread Chani
On April 10, 2009 18:25:49 Aaron J. Seigo wrote: > On Friday 10 April 2009, Chani wrote: > > I'm still wondering... why does the existing screensaver restacking code > > not work on these popups? > > hazarding a complete guess: because we mark the windows to be ignored by > the window manager. and

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-11 Thread Marco Martin
On 4/11/09, Aaron J. Seigo wrote: > On Friday 10 April 2009, Chani wrote: > > I'm still wondering... why does the existing screensaver restacking code > > not work on these popups? > > > hazarding a complete guess: because we mark the windows to be ignored by the > window manager. and apparentl

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-10 Thread Aaron J. Seigo
On Friday 10 April 2009, Chani wrote: > I'm still wondering... why does the existing screensaver restacking code > not work on these popups? hazarding a complete guess: because we mark the windows to be ignored by the window manager. and apparently that means no help, not even for the screensave

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-10 Thread Chani
On April 9, 2009 21:36:13 Lucas Murray wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/546/#review890 > --- > > > Although the ol

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-10 Thread Aaron Seigo
> On 2009-04-09 21:36:18, Lucas Murray wrote: > > Although the old code also used the tool window type I would highly > > recommend against using the same technique again as it's only by chance > > that it does what it does and can be broken fairly innocently by both > > developers working on

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-09 Thread Lucas Murray
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/#review890 --- Although the old code also used the tool window type I would highly reco

Re: Review Request: Prevent Plasma popups from showing over screensaver

2009-04-09 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/ --- (Updated 2009-04-09 09:04:21.007123) Review request for Plasma. Summary ---

Review Request: Prevent Plasma popups from showing over screensaver

2009-04-09 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/546/ --- Review request for Plasma. Summary --- Use Qt::Tool window flag to prevent p