---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/#review5677
---
Ship it!
I basically like how it works. There are minor issues from
2010/5/4 Christophe Olinger oling...@binarylooks.com
On 2010-05-03 14:36:29, Alessandro Diaferia wrote:
Applied all the suggestions. Thanks for the QFlags idea.
For the next patch I'll review all my functions and variables for const
and virtual and pure virtual. It'll also include all
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
(Updated 2010-05-09 19:09:50.561579)
Review request for Plasma and Alessandro
On 2010-05-03 14:36:29, Alessandro Diaferia wrote:
Applied all the suggestions. Thanks for the QFlags idea.
For the next patch I'll review all my functions and variables for const and
virtual and pure virtual. It'll also include all the stuff that I showed in
my blog post.
- Christophe
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/#review5322
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
(Updated 2010-04-27 16:44:10.137339)
Review request for Plasma and Alessandro
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
(Updated 2010-04-26 07:05:03.590082)
Review request for Plasma and Alessandro
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/#review5115
---
I included some comments of the code so that we better see which
On 2010-04-19 07:59:49, Alessandro Diaferia wrote:
I just had a quick look at the patch, i'm rather busy atm :/
Anyway, i still have concerns about the subcomponents placement stuff.
Rather than having WidgetAndZone approach imho we should enhance
MediaController API in order to
On 2010-04-19 07:59:49, Alessandro Diaferia wrote:
I just had a quick look at the patch, i'm rather busy atm :/
Anyway, i still have concerns about the subcomponents placement stuff.
Rather than having WidgetAndZone approach imho we should enhance
MediaController API in order to
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
(Updated 2010-04-19 19:43:39.677273)
Review request for Plasma and Alessandro
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
(Updated 2010-04-15 17:55:32.714768)
Review request for Plasma and Alessandro
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
(Updated 2010-04-14 13:52:37.746381)
Review request for Plasma and Alessandro
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
(Updated 2010-04-11 11:49:19.125531)
Review request for Plasma and Alessandro
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/#review4968
---
Still haven't tried the patch locally but i'd like the
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3552/
---
Review request for Plasma and Alessandro Diaferia.
Summary
---
The state
16 matches
Mail list logo