Re: Review Request: Save scrollbar position on plasma exit

2012-03-17 Thread Ignat Semenov
On March 13, 2012, 1:12 p.m., Marco Martin wrote: looks good, a thing i would like to be tested is when the saved position is invalid, like either negative or an enormous value. this shouldn't break it (is even quite probable a value not being valid anymore because there are less

Re: Review Request: Save scrollbar position on plasma exit

2012-03-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 16, 2012, 10:02 a.m.) Review request for Plasma, Aaron J.

Re: Review Request: Save scrollbar position on plasma exit

2012-03-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 16, 2012, 1:47 p.m.) Review request for Plasma, Aaron J.

Re: Review Request: Save scrollbar position on plasma exit

2012-03-16 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 16, 2012, 4:31 p.m.) Review request for Plasma, Aaron J.

Re: Review Request: Save scrollbar position on plasma exit

2012-03-14 Thread Ignat Semenov
On March 13, 2012, 1:12 p.m., Marco Martin wrote: looks good, a thing i would like to be tested is when the saved position is invalid, like either negative or an enormous value. this shouldn't break it (is even quite probable a value not being valid anymore because there are less

Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- Review request for Plasma, Aaron J. Seigo, Marco Martin, and Fredrik

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 13, 2012, 1:06 p.m.) Review request for Plasma, Aaron J.

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/#review11354 --- looks good, a thing i would like to be tested is when the

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 13, 2012, 1:51 p.m.) Review request for Plasma, Aaron J.

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Fredrik Höglund
On March 13, 2012, 1:12 p.m., Marco Martin wrote: looks good, a thing i would like to be tested is when the saved position is invalid, like either negative or an enormous value. this shouldn't break it (is even quite probable a value not being valid anymore because there are less

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
On March 13, 2012, 1:12 p.m., Marco Martin wrote: looks good, a thing i would like to be tested is when the saved position is invalid, like either negative or an enormous value. this shouldn't break it (is even quite probable a value not being valid anymore because there are less

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
On March 13, 2012, 1:12 p.m., Marco Martin wrote: looks good, a thing i would like to be tested is when the saved position is invalid, like either negative or an enormous value. this shouldn't break it (is even quite probable a value not being valid anymore because there are less

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/ --- (Updated March 13, 2012, 6:44 p.m.) Review request for Plasma, Aaron J.