Re: Review Request: The preview action shouldn't be visible all the time

2012-09-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/#review19391 --- This review has been submitted with commit 19792002e9e8055c052

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-19 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/#review19157 --- Ship it! Ship It! - Sebastian Kügler On Sept. 19, 2012, 11:

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-19 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/ --- (Updated Sept. 19, 2012, 11:13 a.m.) Review request for Plasma. Changes

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-19 Thread Giorgos Tsiapaliwkas
> On Sept. 17, 2012, 4:13 p.m., Sebastian Kügler wrote: > > mainwindow.cpp, line 975 > > > > > > Do we setVisible(true) it when we change package? > > > > I don't see this in the code, but haven't tried. So

Re: Review Request: The preview action shouldn't be visible all the time

2012-09-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/#review19077 --- mainwindow.cpp

Review Request: The preview action shouldn't be visible all the time

2012-09-17 Thread Giorgos Tsiapaliwkas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106477/ --- Review request for Plasma. Description --- This patches fixes the abo