Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-03 Thread Riccardo Iaconelli
On Tuesday 02 December 2008 19:47:27 Chani wrote: > speaking of unexpected scrolling... while I loved the scrollwheel-timezones > feature in kde3, it's pissing me off in kde4. several times now I've > accidentally scrolled into the next timezone, and not noticed for a few > hours that my clock is s

Re: Res: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-03 Thread Michael Rudolph
On Mon, Dec 1, 2008 at 19:12, Fabrizio Montesi <[EMAIL PROTECTED]> wrote: > On Monday 01 December 2008 18:50:18 [EMAIL PROTECTED] wrote: >> >sorry, what does moving the mouse wheel over the battery icon have to do >> > >with the brightness of my screen? >> > >> >at the very least it requires onscre

Re: Res: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-02 Thread Aaron J. Seigo
On Tuesday 02 December 2008, Chani wrote: > > Changing something by moving the mouse wheel over a battery is > > something I wouldn't expect. > > speaking of unexpected scrolling... while I loved the scrollwheel-timezones > feature in kde3, it's pissing me off in kde4. several times now I've > acci

Re: Res: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-02 Thread Chani
> Changing something by moving the mouse wheel over a battery is > something I wouldn't expect. speaking of unexpected scrolling... while I loved the scrollwheel-timezones feature in kde3, it's pissing me off in kde4. several times now I've accidentally scrolled into the next timezone, and not

Re: Res: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-01 Thread Sebastian Kügler
On Monday 01 December 2008 19:12:35 Fabrizio Montesi wrote: > What I always thought as "could be pretty" is that moving the wheel over > the brightness bar in the battery plasmoid should change its value. Now, > that I would expect and be pleased by. This works in trunk, it has been fixed yesterda

Re: Res: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-01 Thread Fabrizio Montesi
On Monday 01 December 2008 18:50:18 [EMAIL PROTECTED] wrote: > >sorry, what does moving the mouse wheel over the battery icon have to do > > >with the brightness of my screen? > > > >at the very least it requires onscreen notification, but it really seems > > >like an odd feature. > > I do agree, a

Res: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-01 Thread dantti85-dev
iew Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top. On Monday 01 December 2008, Sebastian Kügler wrote: > On Monday 01 December 2008 14:32:39 Gökmen GÖKSEL wrote: > > On Monday 01 December 2008 03:14:17 Aaron Seigo wrote: > > >

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-01 Thread Sebastian Kügler
On Monday 01 December 2008 14:32:39 Gökmen GÖKSEL wrote: > On Monday 01 December 2008 03:14:17 Aaron Seigo wrote: > > hm. i actually take that "Ship it!" back .. i don't think it makes any > > sense to change the screen brightness when scrolling over the battery > > icon. coupled with the fact that

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-01 Thread Aaron J. Seigo
On Monday 01 December 2008, Sebastian Kügler wrote: > On Monday 01 December 2008 14:32:39 Gökmen GÖKSEL wrote: > > On Monday 01 December 2008 03:14:17 Aaron Seigo wrote: > > > hm. i actually take that "Ship it!" back .. i don't think it makes any > > > sense to change the screen brightness when scr

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-12-01 Thread Gökmen GÖKSEL
On Monday 01 December 2008 03:14:17 Aaron Seigo wrote: > hm. i actually take that "Ship it!" back .. i don't think it makes any > sense to change the screen brightness when scrolling over the battery icon. > coupled with the fact that there is no user feedback when this happens > (other than the sc

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/#review280 --- hm. i actually take that "Ship it!" back .. i don't think it makes

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/ --- (Updated 2008-11-30 16:50:43.740914) Review request for Plasma. Summary -

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/ --- (Updated 2008-11-30 16:34:10.712762) Review request for Plasma. Summary -

Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/ --- Review request for Plasma. Summary --- A patch that makes the Battery

Re: Review Request: This patch add an easy way to up/down brightness only scrolling on battery plasmoid top.

2008-11-30 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/286/#review279 --- Ship it! float->qreal for portability, otherwise, looks good =)