On July 12, 2010, Marco Martin wrote:
a) retrieve become asymmetric with store and retrieve everything while
store does for a single key value pair
that's fine.
b) not using a service anymore,
would be directly kconfig, akonadi or whatever
this would be a break with the plasma
On July 13, 2010, Marco Martin wrote:
and are you for using akonadi at all, sticking with kconfig?
i'm fine with akonadi, but i don't think kconfig is a great fit. though it
seems we're in agreement there:
even if i don't really know it, akonadi really feels way more heavy duty
and suitable
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4548/#review6497
---
/trunk/KDE/kdelibs/plasma/datacontainer.h
On 2010-07-10 08:35:01, Aaron Seigo wrote:
/trunk/KDE/kdelibs/plasma/dataengine.cpp, line 803
http://reviewboard.kde.org/r/4548/diff/1/?file=30539#file30539line803
this will work ok for low latency / synchronous storage fetching, which
is what the current implementation is. but
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4548/
---
(Updated 2010-07-12 20:10:03.795472)
Review request for Plasma.
Changes
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4548/#review6511
---
Ship it!
I think it can go in now
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4548/#review6459
---
a good start. there are a number of rough edges that need to be
On 2010-07-10 08:35:01, Aaron Seigo wrote:
/trunk/KDE/kdelibs/plasma/datacontainer.cpp, line 153
http://reviewboard.kde.org/r/4548/diff/1/?file=30537#file30537line153
needsCacheing()?
sounds pretty awful as well.
what about replacing all references to cache in the api to storage?
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4548/
---
Review request for Plasma.
Summary
---
DataEngines can mark or unmark
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4548/#review6432
---
Ship it!
i did looked at it quite a bit while in branch, i think
10 matches
Mail list logo