Re: Review Request: Window runner to switch windows and desktops

2009-07-28 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/ --- (Updated 2009-07-28 15:06:18.013103) Review request for Plasma. Changes

Re: Review Request: Window runner to switch windows and desktops

2009-07-28 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1825 --- Ship it! i think we may need to hook up the KWindowSystem signals in

Re: Review Request: Window runner to switch windows and desktops

2009-07-28 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1828 --- Looks good :)

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/ --- (Updated 2009-07-26 10:21:46.864061) Review request for Plasma. Changes

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/ --- (Updated 2009-07-26 12:34:22.065536) Review request for Plasma. Changes

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1788 --- trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Martin Gräßlin
On 2009-07-26 15:44:49, Ryan Bitanga wrote: trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp, line 129 http://reviewboard.kde.org/r/1114/diff/4/?file=9093#file9093line129 One of the reasons I worked on multiple action support for KRunner in 4.2 was so that

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Aaron Seigo
On 2009-07-26 15:44:49, Ryan Bitanga wrote: trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp, line 129 http://reviewboard.kde.org/r/1114/diff/4/?file=9093#file9093line129 One of the reasons I worked on multiple action support for KRunner in 4.2 was so that

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1792 --- my only comment is that it would be nice if one could type close kop

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1793 --- ok, now the implementation review part of things :) one thing that

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Martin Gräßlin
On 2009-07-26 19:19:43, Aaron Seigo wrote: ok, now the implementation review part of things :) one thing that is useful to observe about this is that it takes a more memory intensive approach, storing the individual icons, window info and winid of all available windows, to make

Review Request: Window runner to switch windows and desktops

2009-07-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/ --- Review request for Plasma. Summary --- This runner lists the windows and

Re: Review Request: Window runner to switch windows and desktops

2009-07-24 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1732 --- When displaying a matching window, I think it would be better to

Re: Review Request: Window runner to switch windows and desktops

2009-07-24 Thread Martin Gräßlin
On 2009-07-24 12:06:13, Ryan Bitanga wrote: When displaying a matching window, I think it would be better to display the icon of the window itself and not a generic icon for all matches just like what the windows runner in playground does. It might also help to make the window

Re: Review Request: Window runner to switch windows and desktops

2009-07-24 Thread Ryan Bitanga
On 2009-07-24 12:06:13, Ryan Bitanga wrote: When displaying a matching window, I think it would be better to display the icon of the window itself and not a generic icon for all matches just like what the windows runner in playground does. It might also help to make the window

Re: Review Request: Window runner to switch windows and desktops

2009-07-24 Thread Aaron Seigo
On 2009-07-24 12:06:13, Ryan Bitanga wrote: When displaying a matching window, I think it would be better to display the icon of the window itself and not a generic icon for all matches just like what the windows runner in playground does. It might also help to make the window