Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-25 Thread Aaron J. Seigo
On Tuesday, October 25, 2011 16:36:24 Alex Fiestas wrote: > Speaking of this bug, aseigo did you finish the debugging before you went on > vacation ? if so, what was the conclusion ? > > (I'm refering to the potential bug in Qt not emitting destroyed signal). before i left for vacation, i confirm

Re: Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-25 Thread Alex Fiestas
Speaking of this bug, aseigo did you finish the debugging before you went on vacation ? if so, what was the conclusion ? (I'm refering to the potential bug in Qt not emitting destroyed signal). ___ Plasma-devel mailing list Plasma-devel@kde.org https://

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-25 Thread Aaron J. Seigo
On Friday, October 14, 2011 05:19:09 John Stanley wrote: > Hi, > I submitted a patch which hopefully fixes Bug > https://bugs.kde.org/show_bug.cgi?id=275469), > which may be related to this issue (see Comment #50). The patch is > short, so here it is: > > --- kde-workspace-4.7.2.old/libs/taskmanag

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-16 Thread John Stanley
Hi, I submitted a patch which hopefully fixes Bug https://bugs.kde.org/show_bug.cgi?id=275469), which may be related to this issue (see Comment #50). The patch is short, so here it is: --- kde-workspace-4.7.2.old/libs/taskmanager/taskitem.cpp 2011-05-20 16:32:08.0 -0400 +++ kde-

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-05 Thread Craig Drummond
On Wednesday 05 Oct 2011, Aaron J. Seigo wrote: > On Wednesday, October 5, 2011 20:08:55 Craig Drummond wrote: > > I don’t know if its related, but whilst working on IconTasks I noticed > > that items set to be deleted via deleteLater (in > > TaskGroupItem::itemRemoved and TaskManager::TaskItem) we

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-05 Thread Aaron J. Seigo
On Wednesday, October 5, 2011 20:08:55 Craig Drummond wrote: > I don’t know if its related, but whilst working on IconTasks I noticed that > items set to be deleted via deleteLater (in TaskGroupItem::itemRemoved and > TaskManager::TaskItem) were not being deleted until after the app > (plasmoidview

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-05 Thread Craig Drummond
I don’t know if its related, but whilst working on IconTasks I noticed that items set to be deleted via deleteLater (in TaskGroupItem::itemRemoved and TaskManager::TaskItem) were not being deleted until after the app (plasmoidviewer / plasma-desktop) had terminated. To trace this I put debug wh

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102779/#review7115 --- This review has been submitted with commit 4fb69cc9bcda8974a220

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102779/#review7114 --- This review has been submitted with commit 681e1ef4b5f0f7e66d33

Re: Review Request: Workaround Taskbar ghost entries bug

2011-10-05 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102779/#review7107 --- the check makes sense; still wish we knew *where* these odd task

Review Request: Workaround Taskbar ghost entries bug

2011-10-05 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102779/ --- Review request for Plasma and Aaron J. Seigo. Description --- Well, a